-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: User can use Stop Words presets and add custom #3536
Labels
category: model settings
Inference params, presets, templates
category: threads & chat
Threads & chat UI UX issues
P2: nice to have
Nice to have feature
type: feature request
A new feature
Comments
1 task
@nguyenhoangthuan99 however there are some clarifications needed from Inference team. What is the stop token format?
|
imtuyethan
removed
needs designs
Needs designs
needs verification
Needs to be verified, unsure if true
labels
Sep 5, 2024
dan-homebrew
changed the title
feat: Stop Word Settings
feat: User can use Stop Words presets and add custom
Sep 11, 2024
0xSage
added
category: threads & chat
Threads & chat UI UX issues
P2: nice to have
Nice to have feature
type: feature request
A new feature
category: model settings
Inference params, presets, templates
and removed
category: engines
labels
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: model settings
Inference params, presets, templates
category: threads & chat
Threads & chat UI UX issues
P2: nice to have
Nice to have feature
type: feature request
A new feature
Problem
<endofstring>
,<new_sentence>
,<this_is_the_end>
.Solution
From technical aspect, there are 2 cases:
Format
Most of model introduce stop tokens with this format <{content}> . The content is different for each model arch. So I think we can predefine a list option of map model's arch : list stop words like this for user to choses:
Maybe 5 or 6 popular models arch is enough and another option to let users input whatever they want (this feature may be only for power user or dev because normal user might only use default configuration)
Design
Figma: https://www.figma.com/design/DYfpMhf8qiSReKvYooBgDV/Jan-App-(3rd-version)?node-id=8281-97234&t=qb7yU8r2PAayVdNW-4
Default Stop Words:
Predefined Options:
Offer a dropdown preset or quick-select for common stop words based on model architecture
Custom/User-Added Stop Words:
Task
The text was updated successfully, but these errors were encountered: