Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: The version doesn't change when you switch branches #3445

Open
3 of 4 tasks
Enchante503 opened this issue Aug 23, 2024 · 6 comments
Open
3 of 4 tasks

bug: The version doesn't change when you switch branches #3445

Enchante503 opened this issue Aug 23, 2024 · 6 comments
Assignees
Labels
category: app shell Installation, updater, global application issues type: bug Something isn't working

Comments

@Enchante503
Copy link

Enchante503 commented Aug 23, 2024

  • I have searched the existing issues

Current behavior

I started it with make dev but there was an error

The browser's DevTools will appear.

Minimum reproduction step

make dev

and..
Even if you switch the branch to main or Dev and run make dev, the version remains v0.1.0.

Expected behavior

It started without errors.

Screenshots / Logs

jan:dev: [299509:0824/053201.072475:ERROR:CONSOLE(1)] "Uncaught (in promise) TypeError: Failed to fetch", source: devtools://devtools/bundled/panels/elements/elements.js (1)
jan:dev: APPIMAGE env is not defined, current application is not an AppImage
2024-08-24_06h32_04

Jan version

Jan v0.1.0 <-- The version is not 0.5.2 either.
2024-08-28_17h22_19

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Environment details

WSL2 Ubuntu 22.04.4 LTS
Pyenv Python3.11.3 CUDA12.1 torch 2.3.0 cu121

@Enchante503 Enchante503 added the type: bug Something isn't working label Aug 23, 2024
@Enchante503 Enchante503 changed the title bug: [I started it with make dev but there was an error] bug: [The version doesn't change when you switch branches!!] Aug 28, 2024
@Enchante503
Copy link
Author

Enchante503 commented Sep 1, 2024

#3444 (comment)

#2866 (comment)
Someone said that you can switch versions via command line, but there are no instructions in any of the documents. If anyone knows how to do this, please let me know.

@Van-QA
Copy link
Contributor

Van-QA commented Sep 4, 2024

hi @Enchante503,
‌Y‌ou are correc‌t, it's possible to change the version, you can make the modification in electr‌on/package.json, but that is just a la‌bel, to highlight the different build number, just like naming something to make it ea‌sier for discussio‌n / troubleshooting.

Image

If you are already ha‌ve the latest code on the dev branch, the build number label should not affect the app's output. All the latest functions should be included. I hope this can help.

@0xSage
Copy link
Contributor

0xSage commented Sep 5, 2024

Feel free to reopen if you need more help 🙏

@0xSage 0xSage closed this as completed Sep 5, 2024
@Enchante503
Copy link
Author

Hello,
is it just a notation?
Does changing it mean there is no change in functionality?

I'm using GitPull and the latest version of the source code (Zip file),
but I can't convert and input into multiple languages, which should have been resolved.

It is easier to solve problems if information is displayed from the user's perspective, such as which version is being built when launching or building.

@imtuyethan imtuyethan modified the milestone: v0.5.4 Sep 11, 2024
@Enchante503
Copy link
Author

Hi,
I tried edit to build it with a different version as instructed,
but the result remained v0.1.0.
2024-09-13_02h50_52

I'm surprised that there are people who would deceive others. What's so fun about deceiving others?

git clone https://github.com/janhq/jan
cd ./jan
make dev

Please make it clear. Are you saying that with the standard Git clone method, the latest version (e.g., v0.5.3) cannot be used? If there is anything else that needs to be done besides the command mentioned above, please provide clear instructions.

Switching to the main branch with git checkout main did not solve the problem.

If the issue is not resolved even after following any additional instructions that may be provided, I will not engage with Jan again.

@imtuyethan imtuyethan reopened this Sep 29, 2024
@0xSage
Copy link
Contributor

0xSage commented Oct 13, 2024

@urmauur any tips or help you can give here?

@0xSage 0xSage assigned urmauur and unassigned louis-jan Oct 13, 2024
@0xSage 0xSage added the category: app shell Installation, updater, global application issues label Oct 14, 2024
@imtuyethan imtuyethan changed the title bug: [The version doesn't change when you switch branches!!] bug: The version doesn't change when you switch branches Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: app shell Installation, updater, global application issues type: bug Something isn't working
Projects
Status: Scheduled
Development

No branches or pull requests

6 participants