Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Threads - While the model is loading, stop button does not cancelling model load process #2527

Closed
Van-QA opened this issue Mar 28, 2024 · 3 comments
Assignees
Labels
P1: important Important feature / fix type: bug Something isn't working
Milestone

Comments

@Van-QA
Copy link
Contributor

Van-QA commented Mar 28, 2024

Describe the bug:
When the 'Stop' button is clicked during the model load process, the action is not cancelled and the model load continues.

Steps to reproduce:

  1. Navigate to thread
  2. Initiate the model load process.
  3. While the model load is in progress, click on the 'Stop' button.
  4. Observe that the model load process does not stop and continues until completion.

Expected behavior:
When the 'Stop' button is clicked during the model load process, the action should be cancelled immediately and the model load should be terminated.

Screenshots:
Screenshot 2024-03-28 at 16 25 31

Environment details:
Happening on all OS using latest nightly build

@Van-QA Van-QA added the type: bug Something isn't working label Mar 28, 2024
@Van-QA Van-QA added this to the v0.4.11 milestone Mar 28, 2024
@Van-QA
Copy link
Contributor Author

Van-QA commented Mar 28, 2024

Currently, the Nitro does not support cancelling while loading model. Assigning to @tikikun for investigation. cc @louis-jan

@Van-QA
Copy link
Contributor Author

Van-QA commented Apr 5, 2024

Looking good on Jan v0.4.10-363
But when the model stopped, there will be error msg in the UI, will need further investigation from dev team

Image

@Van-QA
Copy link
Contributor Author

Van-QA commented Apr 11, 2024

looking good on Jan v0.4.10-372 ✅

@Van-QA Van-QA closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1: important Important feature / fix type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants