Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Cannot manually import GGUF models #2374

Closed
0xSage opened this issue Mar 15, 2024 · 4 comments
Closed

bug: Cannot manually import GGUF models #2374

0xSage opened this issue Mar 15, 2024 · 4 comments
Assignees
@namchuai
Labels
type: bug Something isn't working
Milestone
v0.4.11

Comments

@0xSage
Copy link
Contributor

0xSage commented Mar 15, 2024

Describe the bug
A clear and concise description of what the bug is.

Steps to reproduce
Steps to reproduce the behavior:

  1. Go to Model Hub
  2. Click import model
  3. Choose the correct filepath
  4. No models are shown; Jan doesnt seem to detect the GGUF model in the folder

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your issue.

Regular Folder View
image

When importing models with Jan
image

Environment details

  • Operating System: Windows 11
  • Jan Version: 0.4.8.324
  • Processor: AMD Ryzen 9
  • VRAM: 8GB 4070
@0xSage 0xSage added the type: bug Something isn't working label Mar 15, 2024
@Van-QA Van-QA added this to the v0.4.9 milestone Mar 15, 2024
@namchuai
Copy link
Contributor

@0xSage this is actually an issue from electron team: electron/electron#9411

If we showing files inside folder, we can't select to import a folder anymore.

@namchuai
Copy link
Contributor

namchuai commented Mar 15, 2024 •
edited
Loading

FYI, we are discussing about this. @imtuyethan

So @louis-jan thinks that we should have additional step to ask user for the way he/she wants to import model: Select Folder or Select Files.

On Mac/Linux, we can skip this step.

@Van-QA Van-QA modified the milestones: v0.4.9, v0.4.10 Mar 15, 2024
@namchuai namchuai mentioned this issue Mar 25, 2024
Merged
3 tasks
@Van-QA Van-QA modified the milestones: v0.4.10, v0.4.11 Mar 25, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Apr 9, 2024

Testing on Jan v0.4.10-366 ✅

When users choose GGUF, we might want to filter only GGUF format, I'm not sure if that is possible, but a nice to have feature cc: @namchuai
Image

Image

@namchuai namchuai mentioned this issue Apr 9, 2024
Merged
3 tasks
@Van-QA
Copy link
Contributor

Van-QA commented Apr 9, 2024

Image

looking good on Jan v0.4.10-367 ✅

@Van-QA Van-QA closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namchuai namchuai

Labels
type: bug Something isn't working
Projects
Jan Project
Archived in project
Milestone
v0.4.11
Development

No branches or pull requests
3 participants
@namchuai @Van-QA @0xSage