Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: model.json doesn't have any required params #1028

Closed
Tracked by #1227
0xSage opened this issue Dec 15, 2023 · 4 comments · Fixed by #1314
Closed
Tracked by #1227

feat: model.json doesn't have any required params #1028

0xSage opened this issue Dec 15, 2023 · 4 comments · Fixed by #1314
Assignees
Labels
P0: critical Mission critical type: feature request A new feature

Comments

@0xSage
Copy link
Contributor

0xSage commented Dec 15, 2023

Problem
Per spec, users should only have to modify 1 field for a model to work

source_url: //techincally, the only required field

Success Criteria
A clear and concise description of what you want to happen.

  • Have a global default for model.json
  • Maybe just a fallback via /model-extensions/src/model.json
  • Maybe design a future compatible name i.e. /model-extension/src/gguf-model.json

Additional context

Once this is the case, this issue would be a breeze: #678

@0xSage 0xSage added the type: feature request A new feature label Dec 15, 2023
@0xSage 0xSage added this to the Better Model Hub Experience milestone Dec 15, 2023
@0xSage 0xSage added the P0: critical Mission critical label Dec 18, 2023
@0xSage 0xSage changed the title feat: model.json should have only 1 required param feat: model.json should have only 1 required param "source_url" (if even that) Dec 18, 2023
@namchuai
Copy link
Contributor

Hmm, let's say user import the model locally, which is drag and drop to Jan. Then, source_url might not be relevant, right?

@0xSage
Copy link
Contributor Author

0xSage commented Dec 20, 2023

Hmm, let's say user import the model locally, which is drag and drop to Jan. Then, source_url might not be relevant, right?

I think we still have to think about this from the perspective of technical users who directly mv & edit files.

Then what is absolutely required for models to run - it should be as little fields required as possible.

One option is a global model.json file in /models that specifies the default values of a model.json. It is used as a fallback when individual model.jsons haven't defined certain fields. This also makes it clear to users what the default model settings are.

Open to a more elegant solution here. I really dont know.

Scenarios:

  • User has 1 model binary, but has 2 configurations, e.g. folders model-a-with-params-a and model-a-with-params-b. It doesnt make sense for users to create copies of large model binaries. In this case source_url: ../../model-a/model.gguf would be neat.
  • User decides they want all downloaded models to have max_tokens: 2048 (or some other global default preference), in this case, they'd only have to edit the default model.json once, instead of editing every single model.json in every model download folder. (In fact, the individual model.jsons can be quite sparse)

Happy to chat/debate about this further tomorrow! cc @dan-jan @hiro-v (who were in original discussions about this)

@0xSage
Copy link
Contributor Author

0xSage commented Dec 21, 2023

Update, for RAG /files, we decided to copy over each file upload directly into /thread-id folder.

@0xSage 0xSage changed the title feat: model.json should have only 1 required param "source_url" (if even that) feat: model.json doesn't have any required params Dec 25, 2023
@0xSage 0xSage removed this from the Better Model Hub Experience milestone Dec 27, 2023
namchuai pushed a commit that referenced this issue Jan 3, 2024
namchuai pushed a commit that referenced this issue Jan 4, 2024
namchuai added a commit that referenced this issue Jan 4, 2024
* feat(Model): #1028 made model.json optional

Signed-off-by: James <[email protected]>

---------

Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>
@0xSage
Copy link
Contributor Author

0xSage commented Jan 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0: critical Mission critical type: feature request A new feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants