-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: model.json doesn't have any required params #1028
Comments
Hmm, let's say user import the model locally, which is drag and drop to Jan. Then, |
I think we still have to think about this from the perspective of technical users who directly mv & edit files. Then what is absolutely required for models to run - it should be as little fields required as possible. One option is a global Open to a more elegant solution here. I really dont know. Scenarios:
Happy to chat/debate about this further tomorrow! cc @dan-jan @hiro-v (who were in original discussions about this) |
Update, for RAG |
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
* feat(Model): #1028 made model.json optional Signed-off-by: James <[email protected]> --------- Signed-off-by: James <[email protected]> Co-authored-by: James <[email protected]>
woot
…On Thu, Jan 4, 2024 at 5:50 PM NamH ***@***.***> wrote:
Closed #1028 <#1028> as completed via
#1314 <#1314>.
—
Reply to this email directly, view it on GitHub
<#1028 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQVWFCHPSABEZR6ZHHHBVQDYMZ3PJAVCNFSM6AAAAABAV5YVGGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGM4DONRVGQZTOMY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Problem
Per spec, users should only have to modify 1 field for a model to work
source_url: //techincally, the only required field
Success Criteria
A clear and concise description of what you want to happen.
/model-extensions/src/model.json
/model-extension/src/gguf-model.json
Additional context
Once this is the case, this issue would be a breeze: #678
The text was updated successfully, but these errors were encountered: