Skip to content

Commit

Permalink
fix: suppress all main node JS error messages
Browse files Browse the repository at this point in the history
  • Loading branch information
louis-jan committed Jan 8, 2024
1 parent d19e8ba commit a7b5e06
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 11 deletions.
19 changes: 8 additions & 11 deletions electron/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 2,6 @@ import { app, BrowserWindow } from 'electron'
import { join } from 'path'
import { setupMenu } from './utils/menu'
import { createUserSpace } from './utils/path'

/**
* Managers
**/
Expand All @@ -19,7 18,7 @@ import { handleAppIPCs } from './handlers/app'
import { handleAppUpdates } from './handlers/update'
import { handleFsIPCs } from './handlers/fs'
import { migrateExtensions } from './utils/migration'
import { dispose } from './utils/disposable'
import { cleanUpAndQuit } from './utils/clean'

app
.whenReady()
Expand Down Expand Up @@ -89,12 88,10 @@ function handleIPCs() {
handleFileMangerIPCs()
}

function cleanUpAndQuit() {
if (!ModuleManager.instance.cleaningResource) {
ModuleManager.instance.cleaningResource = true
WindowManager.instance.currentWindow?.destroy()
dispose(ModuleManager.instance.requiredModules)
ModuleManager.instance.clearImportedModules()
app.quit()
}
}
/*
** Suppress Node error messages
*/
process.on('uncaughtException', function (err) {
// TODO: Write error to log file in #1447
console.log(err)
})
14 changes: 14 additions & 0 deletions electron/utils/clean.ts
Original file line number Diff line number Diff line change
@@ -0,0 1,14 @@
import { ModuleManager } from '@janhq/core/node'
import { WindowManager } from './../managers/window'
import { dispose } from './disposable'
import { app } from 'electron'

export function cleanUpAndQuit() {
if (!ModuleManager.instance.cleaningResource) {
ModuleManager.instance.cleaningResource = true
WindowManager.instance.currentWindow?.destroy()
dispose(ModuleManager.instance.requiredModules)
ModuleManager.instance.clearImportedModules()
app.quit()
}
}

0 comments on commit a7b5e06

Please sign in to comment.