Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networking: match multiple VIPs in HTTP route #52192

Merged

Conversation

jewertow
Copy link
Member

@jewertow jewertow commented Jul 19, 2024

Please provide a description of this PR:

This is a follow-up to #51967.

@jewertow jewertow requested a review from a team as a code owner July 19, 2024 21:15
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 19, 2024
Signed-off-by: Jacek Ewertowski <[email protected]>
@jewertow
Copy link
Member Author

/test integ-ambient-ipv6

@jewertow
Copy link
Member Author

If it comes to integration tests, this is already covered by TestServiceEntryInlinedWorkloadEntry and that test was failing before this change, look at this: #52188 (comment).

@howardjohn
Copy link
Member

Awesome, thanks!

@istio-testing istio-testing merged commit 09d06a3 into istio:master Jul 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants