networking: match multiple VIPs in sidecar outbound listener #51967

jewertow · 2024-07-09T11:27:04Z

Please provide a description of this PR:

What did I change:

GetAllAddressesForProxy and GetExtraAddressesForProxy always return all addresses for the proxy's IP family. Previously these functions were returning all addresses only when ISTIO_DUAL_STACK was enabled.
buildSidecarOutboundListener used these functions to configure CIDR matching. These functions always returned the default address, so outbound listeners couldn't match all the addresses. Now, all CIDRs are configured for the supported IP family.
convertServices created internal service instance for each [host, address] pair. Now, it creates an instance for each [host, address list] pair.

Example:
When the following SE is applied:

apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: dns
spec:
  hosts:
  - "fake.service.local"
  addresses:
  - 10.123.16.192/28
  - 10.123.16.208/28
  - 10.123.16.224/28
  location: MESH_EXTERNAL
  resolution: NONE
  ports:
  - number: 9092
    name: tcp
    protocol: TCP

and I check listeners for port 9092:

istioctl pc l deploy/sleep --port 9092

I get the following results:

Istio 1.21:

ADDRESSES PORT MATCH                  DESTINATION
0.0.0.0   9092 ALL                    PassthroughCluster
0.0.0.0   9092 Addr: 10.123.16.192/28 Cluster: outbound|9092||fake.service.local
0.0.0.0   9092 Addr: 10.123.16.208/28 Cluster: outbound|9092||fake.service.local
0.0.0.0   9092 Addr: 10.123.16.224/28 Cluster: outbound|9092||fake.service.local

Istio 1.22:

ADDRESSES PORT MATCH                  DESTINATION
0.0.0.0   9092 ALL                    PassthroughCluster
0.0.0.0   9092 Addr: 10.123.16.192/28 Cluster: outbound|9092||fake.service.local

This branch:

ADDRESSES PORT MATCH                                                    DESTINATION
0.0.0.0   9092 ALL                                                      PassthroughCluster
0.0.0.0   9092 Addr: 10.123.16.192/28,10.123.16.208/28,10.123.16.224/28 Cluster: outbound|9092||fake.service.local

istio-testing · 2024-07-09T11:27:06Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

jewertow · 2024-07-09T11:27:25Z

/test all

hzxuzhonghu

Is this a breaking change

hzxuzhonghu

Dual stack usage percentage is less compared with pure ipv4

jewertow · 2024-07-15T07:52:22Z

Is this a breaking change

Dual stack usage percentage is less compared with pure ipv4

@hzxuzhonghu I am not sure if I understand what you mean, but this change does not enable dual-stack by default. GetAllAddressesForProxy will always return all addresses for the proxy's IP family, i.e. if a proxy is IPv4, then GetAllAddressesForProxy will return all IPv4 addresses. Similarly for IPv6. All addresses, IPv4 and IPv6, will be returned only if DUAL_STACK is enabled.

Signed-off-by: Jacek Ewertowski <[email protected]>

jewertow · 2024-07-16T13:19:11Z

I wonder though if having only a GetAllAddresses and update existing code to use it

Actually, that was my initial approach, but I ended up in settings addresses[0] and addresses[1:], etc., and then I thought that someone added these functions for a reason, and maybe I shouldn't change it.

Anyway, if you also think that we should use only single function to get addresses, I could do it in a near future, and now I would like to focus on making it work for HTTP as well. At the end I will submit a PR that will unify usage of these functions. What do you think?

leosarra · 2024-07-16T13:42:12Z

Actually, that was my initial approach, but I ended up in settings addresses[0] and addresses[1:], etc., and then I thought that someone added these functions for a reason, and maybe I shouldn't change it.

I'm pretty sure that the original reasoning regarding that separation was made by Steve in order to keep single-stack and DS code as separated as possible. Now that the getAllAddresses became relevant for other usecases it would make sense to revisit that decision.
I agree, it does not make sense to refactor it as part of this PR. Either of us can tackle it in the future 😊

howardjohn · 2024-07-16T14:05:58Z

LGTM, seems like the current concerns are just refactorings around DS handling in the future?

keithmattix

I'm a general 1; I think this is a needed change that reduces the complexity of our dualstack support. I also agree with a lot of the other cleanup comments, but this is a good first step

pilot/pkg/model/service.go

keithmattix · 2024-07-16T16:49:26Z

pilot/pkg/model/service.go

+ }
+ if node.SupportsIPv6() && len(ipv6Addresses) > 0 {
+ return ipv6Addresses
+ }
 }
 if a := s.GetAddressForProxy(node); a != "" {


Yeah I'd recommend renaming this function at some point (fast followup?); it's getting difficult to know what each one does

Signed-off-by: Jacek Ewertowski <[email protected]>

hzxuzhonghu · 2024-07-17T04:20:45Z

pilot/pkg/model/service.go

 addresses := s.ClusterVIPs.GetAddressesFor(node.Metadata.ClusterID)
+ if (features.EnableDualStack || features.EnableAmbient) && len(addresses) > 0 {


donot we need to check whether pod support dual stack?

Like a multi cluster mesh, one cluster support only ipv4, the other support dual stack

No, this function returns addresses relevant for the cluster of the requesting proxy.

Btw. this is irrelevant in this PR, as I didn't change anything related to dual-stack.

Yes, none of your bussiness. Just see this and indeed it is a bug

In general, we shouldn't be making decisions based on EnableDualStack and should treat it as a deprecated field - it's almost never the correct signal to check, yes.

jewertow · 2024-07-17T06:37:02Z

@hzxuzhonghu as you requested changes, could you clarify what do you expect to be changed? You didn't point any issue, just raised your concerns, so this is confusing. And now it only waits for your approval.

hzxuzhonghu · 2024-07-17T06:49:42Z

pilot/pkg/model/service.go

 addresses := s.ClusterVIPs.GetAddressesFor(node.Metadata.ClusterID)
+ if (features.EnableDualStack || features.EnableAmbient) && len(addresses) > 0 {


Yes, none of your bussiness. Just see this and indeed it is a bug

istio-testing · 2024-07-18T09:16:43Z

In response to a cherrypick label: new pull request created: #52148

istio-testing · 2024-07-19T15:12:17Z

In response to a cherrypick label: #51967 failed to apply on top of branch "release-1.22":

Applying: networking: match multiple addresses in sidecar outbound listener
Using index info to reconstruct a base tree...
M	pilot/pkg/model/service.go
M	pilot/pkg/networking/core/listener.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/networking/core/listener.go
Auto-merging pilot/pkg/model/service.go
CONFLICT (content): Merge conflict in pilot/pkg/model/service.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 networking: match multiple addresses in sidecar outbound listener
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

istio-testing · 2024-07-19T15:12:18Z

In response to a cherrypick label: new issue created for failed cherrypick: #52184

istio-testing · 2024-07-19T15:12:56Z

In response to a cherrypick label: new pull request could not be created: failed to create pull request against istio/istio#release-1.23 from head istio-testing:cherry-pick-51967-to-release-1.23: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-51967-to-release-1.23."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

…1967) * networking: match multiple addresses in sidecar outbound listener Signed-off-by: Jacek Ewertowski <[email protected]> * Add unit tests for GetAllAddressesForProxy Signed-off-by: Jacek Ewertowski <[email protected]> * Refactor buildSidecarOutboundListener Signed-off-by: Jacek Ewertowski <[email protected]> * Add an integration test Signed-off-by: Jacek Ewertowski <[email protected]> * Add a release note Signed-off-by: Jacek Ewertowski <[email protected]> * Refactor GetAllAddressesForProxy Signed-off-by: Jacek Ewertowski <[email protected]> * Fix linter error Signed-off-by: Jacek Ewertowski <[email protected]> * Revert removal svcExtraListenAddresses variable Signed-off-by: Jacek Ewertowski <[email protected]> * Fix unit tests Signed-off-by: Jacek Ewertowski <[email protected]> * Refactoring Signed-off-by: Jacek Ewertowski <[email protected]> * Fix TestEDSOverlapping Signed-off-by: Jacek Ewertowski <[email protected]> * Skip testServiceEntryWithMultipleVIPs in ambient mode Signed-off-by: Jacek Ewertowski <[email protected]> * Fix TestEDSUnhealthyEndpoints Signed-off-by: Jacek Ewertowski <[email protected]> * Add test case for ServiceEntry with resolution NONE and multiple VIPs Signed-off-by: Jacek Ewertowski <[email protected]> * Fix lint error Signed-off-by: Jacek Ewertowski <[email protected]> * Fix linter errors Signed-off-by: Jacek Ewertowski <[email protected]> * Fix lint error Signed-off-by: Jacek Ewertowski <[email protected]> * Generate service with all ports Signed-off-by: Jacek Ewertowski <[email protected]> * do not create service instance for each hostname/address pair Signed-off-by: Jacek Ewertowski <[email protected]> * Refactor GetExtraAddressesForProxy and revert removal of its usage from buildSidecarOutboundListener Signed-off-by: Jacek Ewertowski <[email protected]> * Fix listenerBindings.Extra() Signed-off-by: Jacek Ewertowski <[email protected]> * Handle IPv6 prefix length Signed-off-by: Jacek Ewertowski <[email protected]> * Check address' family only if a proxy supports given family Signed-off-by: Jacek Ewertowski <[email protected]> * Update a comment Signed-off-by: Jacek Ewertowski <[email protected]> * Refactor getAllAddressesForProxy Signed-off-by: Jacek Ewertowski <[email protected]> --------- Signed-off-by: Jacek Ewertowski <[email protected]>

…stener (#52249) * networking: match multiple VIPs in sidecar outbound listener (#51967) * networking: match multiple addresses in sidecar outbound listener Signed-off-by: Jacek Ewertowski <[email protected]> * Add unit tests for GetAllAddressesForProxy Signed-off-by: Jacek Ewertowski <[email protected]> * Refactor buildSidecarOutboundListener Signed-off-by: Jacek Ewertowski <[email protected]> * Add an integration test Signed-off-by: Jacek Ewertowski <[email protected]> * Add a release note Signed-off-by: Jacek Ewertowski <[email protected]> * Refactor GetAllAddressesForProxy Signed-off-by: Jacek Ewertowski <[email protected]> * Fix linter error Signed-off-by: Jacek Ewertowski <[email protected]> * Revert removal svcExtraListenAddresses variable Signed-off-by: Jacek Ewertowski <[email protected]> * Fix unit tests Signed-off-by: Jacek Ewertowski <[email protected]> * Refactoring Signed-off-by: Jacek Ewertowski <[email protected]> * Fix TestEDSOverlapping Signed-off-by: Jacek Ewertowski <[email protected]> * Skip testServiceEntryWithMultipleVIPs in ambient mode Signed-off-by: Jacek Ewertowski <[email protected]> * Fix TestEDSUnhealthyEndpoints Signed-off-by: Jacek Ewertowski <[email protected]> * Add test case for ServiceEntry with resolution NONE and multiple VIPs Signed-off-by: Jacek Ewertowski <[email protected]> * Fix lint error Signed-off-by: Jacek Ewertowski <[email protected]> * Fix linter errors Signed-off-by: Jacek Ewertowski <[email protected]> * Fix lint error Signed-off-by: Jacek Ewertowski <[email protected]> * Generate service with all ports Signed-off-by: Jacek Ewertowski <[email protected]> * do not create service instance for each hostname/address pair Signed-off-by: Jacek Ewertowski <[email protected]> * Refactor GetExtraAddressesForProxy and revert removal of its usage from buildSidecarOutboundListener Signed-off-by: Jacek Ewertowski <[email protected]> * Fix listenerBindings.Extra() Signed-off-by: Jacek Ewertowski <[email protected]> * Handle IPv6 prefix length Signed-off-by: Jacek Ewertowski <[email protected]> * Check address' family only if a proxy supports given family Signed-off-by: Jacek Ewertowski <[email protected]> * Update a comment Signed-off-by: Jacek Ewertowski <[email protected]> * Refactor getAllAddressesForProxy Signed-off-by: Jacek Ewertowski <[email protected]> --------- Signed-off-by: Jacek Ewertowski <[email protected]> * Revert unintentional change of a comment Signed-off-by: Jacek Ewertowski <[email protected]> --------- Signed-off-by: Jacek Ewertowski <[email protected]>

…1967) * networking: match multiple addresses in sidecar outbound listener Signed-off-by: Jacek Ewertowski <[email protected]> * Add unit tests for GetAllAddressesForProxy Signed-off-by: Jacek Ewertowski <[email protected]> * Refactor buildSidecarOutboundListener Signed-off-by: Jacek Ewertowski <[email protected]> * Add an integration test Signed-off-by: Jacek Ewertowski <[email protected]> * Add a release note Signed-off-by: Jacek Ewertowski <[email protected]> * Refactor GetAllAddressesForProxy Signed-off-by: Jacek Ewertowski <[email protected]> * Fix linter error Signed-off-by: Jacek Ewertowski <[email protected]> * Revert removal svcExtraListenAddresses variable Signed-off-by: Jacek Ewertowski <[email protected]> * Fix unit tests Signed-off-by: Jacek Ewertowski <[email protected]> * Refactoring Signed-off-by: Jacek Ewertowski <[email protected]> * Fix TestEDSOverlapping Signed-off-by: Jacek Ewertowski <[email protected]> * Skip testServiceEntryWithMultipleVIPs in ambient mode Signed-off-by: Jacek Ewertowski <[email protected]> * Fix TestEDSUnhealthyEndpoints Signed-off-by: Jacek Ewertowski <[email protected]> * Add test case for ServiceEntry with resolution NONE and multiple VIPs Signed-off-by: Jacek Ewertowski <[email protected]> * Fix lint error Signed-off-by: Jacek Ewertowski <[email protected]> * Fix linter errors Signed-off-by: Jacek Ewertowski <[email protected]> * Fix lint error Signed-off-by: Jacek Ewertowski <[email protected]> * Generate service with all ports Signed-off-by: Jacek Ewertowski <[email protected]> * do not create service instance for each hostname/address pair Signed-off-by: Jacek Ewertowski <[email protected]> * Refactor GetExtraAddressesForProxy and revert removal of its usage from buildSidecarOutboundListener Signed-off-by: Jacek Ewertowski <[email protected]> * Fix listenerBindings.Extra() Signed-off-by: Jacek Ewertowski <[email protected]> * Handle IPv6 prefix length Signed-off-by: Jacek Ewertowski <[email protected]> * Check address' family only if a proxy supports given family Signed-off-by: Jacek Ewertowski <[email protected]> * Update a comment Signed-off-by: Jacek Ewertowski <[email protected]> * Refactor getAllAddressesForProxy Signed-off-by: Jacek Ewertowski <[email protected]> --------- Signed-off-by: Jacek Ewertowski <[email protected]>

…stener (#52283) * networking: match multiple VIPs in sidecar outbound listener (#51967) * networking: match multiple addresses in sidecar outbound listener Signed-off-by: Jacek Ewertowski <[email protected]> * Add unit tests for GetAllAddressesForProxy Signed-off-by: Jacek Ewertowski <[email protected]> * Refactor buildSidecarOutboundListener Signed-off-by: Jacek Ewertowski <[email protected]> * Add an integration test Signed-off-by: Jacek Ewertowski <[email protected]> * Add a release note Signed-off-by: Jacek Ewertowski <[email protected]> * Refactor GetAllAddressesForProxy Signed-off-by: Jacek Ewertowski <[email protected]> * Fix linter error Signed-off-by: Jacek Ewertowski <[email protected]> * Revert removal svcExtraListenAddresses variable Signed-off-by: Jacek Ewertowski <[email protected]> * Fix unit tests Signed-off-by: Jacek Ewertowski <[email protected]> * Refactoring Signed-off-by: Jacek Ewertowski <[email protected]> * Fix TestEDSOverlapping Signed-off-by: Jacek Ewertowski <[email protected]> * Skip testServiceEntryWithMultipleVIPs in ambient mode Signed-off-by: Jacek Ewertowski <[email protected]> * Fix TestEDSUnhealthyEndpoints Signed-off-by: Jacek Ewertowski <[email protected]> * Add test case for ServiceEntry with resolution NONE and multiple VIPs Signed-off-by: Jacek Ewertowski <[email protected]> * Fix lint error Signed-off-by: Jacek Ewertowski <[email protected]> * Fix linter errors Signed-off-by: Jacek Ewertowski <[email protected]> * Fix lint error Signed-off-by: Jacek Ewertowski <[email protected]> * Generate service with all ports Signed-off-by: Jacek Ewertowski <[email protected]> * do not create service instance for each hostname/address pair Signed-off-by: Jacek Ewertowski <[email protected]> * Refactor GetExtraAddressesForProxy and revert removal of its usage from buildSidecarOutboundListener Signed-off-by: Jacek Ewertowski <[email protected]> * Fix listenerBindings.Extra() Signed-off-by: Jacek Ewertowski <[email protected]> * Handle IPv6 prefix length Signed-off-by: Jacek Ewertowski <[email protected]> * Check address' family only if a proxy supports given family Signed-off-by: Jacek Ewertowski <[email protected]> * Update a comment Signed-off-by: Jacek Ewertowski <[email protected]> * Refactor getAllAddressesForProxy Signed-off-by: Jacek Ewertowski <[email protected]> --------- Signed-off-by: Jacek Ewertowski <[email protected]> * Apply missing changes from #51939 Signed-off-by: Jacek Ewertowski <[email protected]> * networking: fix DNS auto-allocation (#52147) * Fix returning auto-allocated address Signed-off-by: Jacek Ewertowski <[email protected]> * Add an integration test Signed-off-by: Jacek Ewertowski <[email protected]> * Add missing build tag and license to dns_auto_allocation_test.go Signed-off-by: Jacek Ewertowski <[email protected]> * Fix unit tests Signed-off-by: Jacek Ewertowski <[email protected]> * Add workload selector to ProxyConfig Signed-off-by: Jacek Ewertowski <[email protected]> * Trigger injection if ProxyConfig was not propagated Signed-off-by: Jacek Ewertowski <[email protected]> --------- Signed-off-by: Jacek Ewertowski <[email protected]> * Remove leftovers from conflict resolution Signed-off-by: Jacek Ewertowski <[email protected]> --------- Signed-off-by: Jacek Ewertowski <[email protected]>

istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 9, 2024

istio-policy-bot added the area/networking label Jul 9, 2024

istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2024

istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 9, 2024

jewertow changed the title ~~networking: match multiple addresses in sidecar outbound listener~~ networking: match multiple VIPs in sidecar outbound listener Jul 9, 2024

jewertow added the area/dual-stack label Jul 9, 2024

jewertow marked this pull request as ready for review July 9, 2024 15:15

jewertow requested review from a team as code owners July 9, 2024 15:15

istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 9, 2024

jewertow requested a review from howardjohn July 10, 2024 08:11

hzxuzhonghu requested changes Jul 15, 2024

View reviewed changes

hzxuzhonghu reviewed Jul 15, 2024

View reviewed changes

jewertow force-pushed the match-multiple-ips-in-sidecar-listener branch 2 times, most recently from f7a5e0b to 0b41890 Compare July 15, 2024 11:18

jewertow added 11 commits July 15, 2024 14:00

networking: match multiple addresses in sidecar outbound listener

b1356eb

Signed-off-by: Jacek Ewertowski <[email protected]>

Add unit tests for GetAllAddressesForProxy

389db0f

Signed-off-by: Jacek Ewertowski <[email protected]>

Refactor buildSidecarOutboundListener

865ae50

Signed-off-by: Jacek Ewertowski <[email protected]>

Add an integration test

04baef7

Signed-off-by: Jacek Ewertowski <[email protected]>

Add a release note

bebe1ac

Signed-off-by: Jacek Ewertowski <[email protected]>

Refactor GetAllAddressesForProxy

c083686

Signed-off-by: Jacek Ewertowski <[email protected]>

Fix linter error

a5d793d

Signed-off-by: Jacek Ewertowski <[email protected]>

Revert removal svcExtraListenAddresses variable

b458c32

Signed-off-by: Jacek Ewertowski <[email protected]>

Fix unit tests

535c2da

Signed-off-by: Jacek Ewertowski <[email protected]>

Refactoring

b30db4d

Signed-off-by: Jacek Ewertowski <[email protected]>

Fix TestEDSOverlapping

4ab355e

Signed-off-by: Jacek Ewertowski <[email protected]>

keithmattix reviewed Jul 16, 2024

View reviewed changes

Refactor getAllAddressesForProxy

31b93da

Signed-off-by: Jacek Ewertowski <[email protected]>

keithmattix approved these changes Jul 16, 2024

View reviewed changes

hzxuzhonghu reviewed Jul 17, 2024

View reviewed changes

jewertow requested a review from hzxuzhonghu July 17, 2024 05:28

hzxuzhonghu approved these changes Jul 17, 2024

View reviewed changes

istio-testing merged commit 2a36b02 into istio:master Jul 17, 2024
28 checks passed

jewertow added the cherrypick/release-1.23 Set this label on a PR to auto-merge it to the release-1.23 branch label Jul 18, 2024

istio-testing mentioned this pull request Jul 18, 2024

[release-1.23] networking: match multiple VIPs in sidecar outbound listener #52148

Closed

jewertow mentioned this pull request Jul 19, 2024

Listeners missing for service entries with TCP ports and multiple addresses [1.22] #51747

Closed

2 tasks

jewertow added the cherrypick/release-1.22 Set this label on a PR to auto-merge it to the release-1.22 branch label Jul 19, 2024

istio-testing mentioned this pull request Jul 19, 2024

[release-1.22] networking: match multiple VIPs in sidecar outbound listener #52184

Open

jewertow mentioned this pull request Jul 19, 2024

networking: match multiple VIPs in HTTP route #52192

Merged

bleggett mentioned this pull request Jul 19, 2024

Deprecate EnableDualStack #52186

Open

jewertow mentioned this pull request Jul 23, 2024

[release-1.23] networking: match multiple VIPs in sidecar outbound listener #52249

Merged

This was referenced Jul 23, 2024

[release-1.22] networking: match multiple VIPs in sidecar outbound listener #52283

Merged

tests: create ServiceEntry with multiple VIPs in DNSTestCases #51995

Merged

Multiple VIPs on Service entry does not work for DNS #30282

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

networking: match multiple VIPs in sidecar outbound listener #51967

networking: match multiple VIPs in sidecar outbound listener #51967

jewertow commented Jul 9, 2024 •

edited

Loading

istio-testing commented Jul 9, 2024

jewertow commented Jul 9, 2024

hzxuzhonghu left a comment

hzxuzhonghu left a comment

jewertow commented Jul 15, 2024

jewertow commented Jul 16, 2024

leosarra commented Jul 16, 2024

howardjohn commented Jul 16, 2024

keithmattix left a comment

keithmattix Jul 16, 2024

hzxuzhonghu Jul 17, 2024

hzxuzhonghu Jul 17, 2024

jewertow Jul 17, 2024

hzxuzhonghu Jul 17, 2024

bleggett Jul 18, 2024 •

edited

Loading

jewertow commented Jul 17, 2024 •

edited

Loading

hzxuzhonghu Jul 17, 2024

istio-testing commented Jul 18, 2024

istio-testing commented Jul 19, 2024

istio-testing commented Jul 19, 2024

istio-testing commented Jul 19, 2024

		addresses := s.ClusterVIPs.GetAddressesFor(node.Metadata.ClusterID)
		if (features.EnableDualStack \|\| features.EnableAmbient) && len(addresses) > 0 {

networking: match multiple VIPs in sidecar outbound listener #51967

networking: match multiple VIPs in sidecar outbound listener #51967

Conversation

jewertow commented Jul 9, 2024 • edited Loading

istio-testing commented Jul 9, 2024

jewertow commented Jul 9, 2024

hzxuzhonghu left a comment

Choose a reason for hiding this comment

hzxuzhonghu left a comment

Choose a reason for hiding this comment

jewertow commented Jul 15, 2024

jewertow commented Jul 16, 2024

leosarra commented Jul 16, 2024

howardjohn commented Jul 16, 2024

keithmattix left a comment

Choose a reason for hiding this comment

keithmattix Jul 16, 2024

Choose a reason for hiding this comment

hzxuzhonghu Jul 17, 2024

Choose a reason for hiding this comment

hzxuzhonghu Jul 17, 2024

Choose a reason for hiding this comment

jewertow Jul 17, 2024

Choose a reason for hiding this comment

hzxuzhonghu Jul 17, 2024

Choose a reason for hiding this comment

bleggett Jul 18, 2024 • edited Loading

Choose a reason for hiding this comment

jewertow commented Jul 17, 2024 • edited Loading

hzxuzhonghu Jul 17, 2024

Choose a reason for hiding this comment

istio-testing commented Jul 18, 2024

istio-testing commented Jul 19, 2024

istio-testing commented Jul 19, 2024

istio-testing commented Jul 19, 2024

jewertow commented Jul 9, 2024 •

edited

Loading

bleggett Jul 18, 2024 •

edited

Loading

jewertow commented Jul 17, 2024 •

edited

Loading