fix(runtime-core): avoid rendering plain object as VNode (vuejs#12038)

close vuejs#12035 close vitejs/vite-plugin-vue#353
ishowman · Sep 26, 2024 · cb34b28 · cb34b28
1 parent faf55a1
commit cb34b28
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/runtime-core/__tests__/rendererChildren.spec.ts b/packages/runtime-core/__tests__/rendererChildren.spec.ts
@@ -65,6  65,15 @@ test('array children -> text children', () => {
   expect(inner(root)).toBe('<div>hello</div>')
 })
 
 test('plain object child', () => {
   const root = nodeOps.createElement('div')
   const foo = { foo: '1' }
   // @ts-expect-error
   render(h('div', null, [foo]), root)
   expect('Invalid VNode type').not.toHaveBeenWarned()
   expect(inner(root)).toBe('<div>[object Object]</div>')
 })
 
 describe('renderer: keyed children', () => {
   let root: TestElement
   let elm: TestElement

diff --git a/packages/runtime-core/src/vnode.ts b/packages/runtime-core/src/vnode.ts
@@ -793,7  793,7 @@ export function normalizeVNode(child: VNodeChild): VNode {
       // #3666, avoid reference pollution when reusing vnode
       child.slice(),
     )
-  } else if (typeof child === 'object') {
   } else if (isVNode(child)) {
     // already vnode, this should be the most common since compiled templates
     // always produce all-vnode children arrays
     return cloneIfMounted(child)