Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to README #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updates to README #28

wants to merge 3 commits into from

Conversation

psarin
Copy link

@psarin psarin commented Jan 19, 2022

Updated instructions on installation
Updated instructions on testing
Added section on additional topics / known issues

Updated instructions on installation
Updated instructions on testing
Added section on additional topics / known issues
@psarin psarin changed the title Updates to README Updated instructions on testing Added section on additional topics / known issues Updates to README Jan 19, 2022
@cubiclabs
Copy link

Something that you might not be aware of is that the SessionInitializerFilter was added to Tomcat some time ago, so if you are using that server you do not need to add the additional jar in - you do still need to modify the web.xml file though:
https://dev.lucee.org/t/installing-the-websocket-extension-on-tomcat-got-much-easier/3012

@redtopia
Copy link

Wow... I never saw that post on the Lucee Dev forum. The jar that you're referring to is servlet-filter-utils-1.1.1.jar correct?

@cubiclabs
Copy link

Yes, that is correct. If you are using Tomcat you do not need the additional jar. Just add the filter as described in the forum post.

@psarin
Copy link
Author

psarin commented Jan 19, 2022

Good to know. I will update the document and re-push.

Copy link

@cubiclabs cubiclabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that in the forum post about this, the filter class is different:

org.apache.catalina.filters.SessionInitializerFilter

instead of

net.twentyonesolutions.servlet.filter.HttpSessionInitializerFilter

This will be Tomcat only. I presume that for Jetty or other servers you will still need to add the jar and the original filter class. Not sure how best to explain that concisely in this readme though.

Add note about non-Tomcat servlet filter
@psarin
Copy link
Author

psarin commented Mar 14, 2022

@isapir Any comments on ths pull request? Do you know if / when it will get accepted / merged? Thanks!


---
>&nbsp;<br/>
>💁🏼‍♀️ &nbsp; Watch the [Chart Server Example](https://www.youtube.com/watch?v=rvB7PcNylVY) tutorial.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should read "Chat Server Example".

@psarin
Copy link
Author

psarin commented Aug 2, 2023

@isapir Are you considering this project dead? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants