Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use lts node version in CI #2259

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

chore: use lts node version in CI #2259

wants to merge 19 commits into from

Conversation

SgtPooki
Copy link
Member

Updates all github workflows selections of node-version to be "lts/*"

SgtPooki and others added 17 commits September 5, 2024 17:57
@SgtPooki SgtPooki requested a review from a team as a code owner September 12, 2024 21:42
@SgtPooki SgtPooki changed the base branch from 2250-webui-spawning-helia-and-failing-to-establish-libp2p-webtransport-connections to main September 12, 2024 21:46
@SgtPooki SgtPooki changed the base branch from main to 2250-webui-spawning-helia-and-failing-to-establish-libp2p-webtransport-connections September 12, 2024 21:46
Base automatically changed from 2250-webui-spawning-helia-and-failing-to-establish-libp2p-webtransport-connections to main September 13, 2024 19:41
An error occurred while trying to automatically change base from 2250-webui-spawning-helia-and-failing-to-establish-libp2p-webtransport-connections to main September 13, 2024 19:41
SgtPooki
SgtPooki commented Sep 24, 2024
View reviewed changes
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

lidel
lidel reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

building with 20 lgtm, but it fails to build for me with v22.4.1, so the CI will break when 24 becomes LTS and someone will have to search for last working version and hardcode it again 😿

is lts/* useful in CI of rarely-maintained apps? i remember the same breackage occuring 12→14→16→18 (nearly every time a change of LTS image broke CI in one of our legacy JS apps)

maybe hardcode to 20.x to avoid headache? (not feeling strongly, i'd just rather not deal with problem once LTS breaks again)

@SgtPooki
Copy link
Member Author

is lts/* useful in CI of rarely-maintained apps? i remember the same breackage occuring 12→14→16→18 (nearly every time a change of LTS image broke CI in one of our legacy JS apps)

most likely not, but we probably want to see a failure when it occurs right?

maybe hardcode to 20.x to avoid headache? (not feeling strongly, i'd just rather not deal with problem once LTS breaks again)

That is good with me, but we should probably target 22 now since it's going active very soon

image

@SgtPooki
Copy link
Member Author

I think once I get ipfs/ipld-explorer-components#448 done, we will be closer to updating everything here.

@SgtPooki SgtPooki mentioned this pull request Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SgtPooki @lidel