Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: test npm build&install against LTS node versions #1967

Merged
merged 33 commits into from
Jul 9, 2022
Merged

feat: test npm build&install against LTS node versions #1967

merged 33 commits into from
Jul 9, 2022

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Jul 9, 2022 •
edited
Loading

I had to clean up branches. This replaces #1962

this new workflow also publishes shields, which would then be published on our README.

README update:

image

workflow results (via https://github.com/SgtPooki/ipfs-webui/actions/runs/2605014389)

image

@SgtPooki
feat: test all os & node versions
20bcfcd 
see ipfs#1940
@SgtPooki
Merge pull request #1 from SgtPooki/1940-cant-build-with-nodejs-v17-a…
3da5258 
…nd-npm-v8

feat: test all os & node versions
@SgtPooki
fix: node-versions.yml does not fail-fast
d8831c0
@SgtPooki
chore: install @mapbox/node-pre-gyp
d51acf1
@SgtPooki
tmp: run on push to main while debugging
d148b54
@SgtPooki
fix: install node-pre-gyp
313df17
@SgtPooki
feat: add os&node build version badges
b0cd5f5
@SgtPooki
fix: node-version badges on success/fail
cb5a9e4
@SgtPooki
feat: Add badges to README.md
19a9719
@SgtPooki
chore: debugging
59e6033
@SgtPooki
fix: node-10.yml name
ff888fa
@SgtPooki
fix: remove triple equals
6809f29
@SgtPooki
fix: reset badge during node-test
99c7d44
@SgtPooki
fix: use explicit badge name
2d6538d
@SgtPooki
fix: use cached node_modules
5eef0f1
@SgtPooki
feat: extract node-test workflow
e967c39
@SgtPooki
docs: update node badges in readme
40a7e56
@SgtPooki
feat: reuse node-test.yml in node-versions.yml
8a8c336
@SgtPooki
chore: remove push trigger for node-10.yml
d2784d1
@SgtPooki
fix: remove badge reset if clause
4fbd1f3
@SgtPooki
feat: use github action concurrency
e179e59
@SgtPooki
fix: do not fail fast
1c39883
@SgtPooki
chore: remove node-10.yl workflow
9974531
@SgtPooki
feat: link node-test badges to workflow page
79cdbd8
@SgtPooki
chore: use fixed package-lock.json from main
a7ee06b
@SgtPooki
Merge remote-tracking branch 'origin' into test-multiple-node-versions
0d78086
@SgtPooki
fix: remove test for node 10.x
55b090f
@SgtPooki
fix: prefer node "lts/*" instead of "18.x"
bcf5414
@SgtPooki
fix: use commit hash for 3p action
31e0dea
@SgtPooki
docs(readme): whitespace fix
b2a7ff9
@SgtPooki SgtPooki requested a review from lidel July 9, 2022 02:33
@SgtPooki SgtPooki self-assigned this Jul 9, 2022
@SgtPooki SgtPooki merged commit 39dc9e9 into ipfs:main Jul 9, 2022
ipfs-gui-bot pushed a commit that referenced this pull request Jul 9, 2022
@semantic-release-bot
chore(release): 2.17.0 [skip ci]
4ab0c43 
## [2.17.0](v2.16.0...v2.17.0) (2022-07-09)

 CID `bafybeicau362acbsnxjbpukuyuufh4vjzw6yoph7wpa67f2rgujdhd3goq`

 ---

### Features

* test npm build&install against LTS node versions ([#1967](#1967)) ([39dc9e9](39dc9e9))

### Trivial Changes

* **readme:** remove node 10.x badge ([b2d63ce](b2d63ce))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 2.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@SgtPooki SgtPooki deleted the test-multiple-node-versions branch February 13, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel Awaiting requested review from lidel

Assignees

@SgtPooki SgtPooki

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SgtPooki @ipfs-gui-bot