Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download button should download from node, not gateway. #2119

Open
kevincox opened this issue Jun 8, 2023 · 2 comments
Open

Download button should download from node, not gateway. #2119

kevincox opened this issue Jun 8, 2023 · 2 comments
Labels
area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/ready Ready to be worked

Comments

@kevincox
Copy link

kevincox commented Jun 8, 2023

Is your feature request related to a problem? Please describe.
When I download a file browsing my local node it often is slow or times out. This is because it is using the gateway rather than downloading from the node's API. This is annoying because I am on the same network as my node and it would be significantly faster, not even counting slowness in DHT traversal that the gateway needs to do.

The "Public Gateway" configuration on the settings page says

Choose which public gateway you want to use when generating shareable links.

A download isn't generating a sharable link so I don't understand why the public gateway should be used. I would expect it to download directly from the node's API.

Describe the solution you'd like
Downloads in the WebUI should use the API, not the public gateway.

Describe alternatives you've considered
Update the docs to state that the gateway is used both for downloads and generating sharable links. This would at least make the product consistent, but doesn't improve the performance issue.

Additional context
The version at the bottom of the WebUI is 2f9f306.
@kevincox kevincox added the need/triage Needs initial labeling and prioritization label Jun 8, 2023
@welcome
Copy link

welcome bot commented Jun 8, 2023

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@github-project-automation github-project-automation bot moved this to Needs Grooming in IPFS-GUI (PL EngRes) Jun 9, 2023
@SgtPooki SgtPooki added kind/bug A bug in existing code (including security flaws) exp/intermediate Prior experience is likely helpful P0 Critical: Tackled by core team ASAP status/ready Ready to be worked area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours and removed need/triage Needs initial labeling and prioritization labels Jun 14, 2023
@SgtPooki SgtPooki moved this from Needs Grooming to Prioritized / Ready for Dev in IPFS-GUI (PL EngRes) Jun 14, 2023
@SgtPooki
Copy link
Member

Thanks for reporting this @kevincox , I noticed this a while back and meant to file an issue for it but I don't think I did. It's a busy next few weeks but I'll try to get to this. It should be a pretty straightforward fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/ready Ready to be worked
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Prioritized / Ready for Dev
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevincox @SgtPooki