Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate DNSLink TXT record #1053

Closed
lidel opened this issue Nov 3, 2023 · 5 comments · Fixed by #1055
Closed

Duplicate DNSLink TXT record #1053

lidel opened this issue Nov 3, 2023 · 5 comments · Fixed by #1055
Assignees
@lidel
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP

Comments

@lidel
Copy link
Member

lidel commented Nov 3, 2023

ipfs ls /ipns/dist.ipfs.tech/kubo/v0.24.0-rc2 is flaky because we have two dnslink TXT records for some reason:

$ dig  short TXT _dnslink.dist.ipfs.tech @1.1.1.1
"dnslink=/ipfs/QmTdbtbfzGrgoFbbeAM3N9kdWWJtUNmm4rGSQGPycnHYYt"
"dnslink=/ipfs/QmegzKtEkh5ST7TWDCRsEwVmBoHhbuQyTuKtHkjVxXWtXj"

DNS spec does not define order of records, and they are returned in random order.
If we are unlucky, we get old one which does not have the RC2, and ipfs ls returns with exit code 1 and error:

Error: no link named "v0.24.0-rc2" under QmZaCQbvsxerzwknjEURf5HQ6ftNsRz6AWAFTut7br6exf

Could be some race condition in dnslink-dnsimple tool this Github Action use for updating DNSLink at DNSimple, or a bug in DNSSimple (our DNS host) itself.
@lidel lidel added the kind/bug A bug in existing code (including security flaws) label Nov 3, 2023
@lidel lidel self-assigned this Nov 3, 2023
@lidel
Copy link
Member Author

lidel commented Nov 3, 2023

I've removed duplicate DNS TXT records (for both .io and .tech), and the issue is resolved.

I'm assuming a hiccup on the dnsimple end, but if we have this problem again, we need to investigate the https://www.npmjs.com/package/dnslink-dnsimple angle, maybe API changed, and we need to update that tool.

@lidel lidel closed this as completed Nov 3, 2023
@lidel lidel mentioned this issue Nov 5, 2023
Closed
@hacdias hacdias reopened this Nov 8, 2023
@hacdias
Copy link
Member

hacdias commented Nov 8, 2023

It's happening again, I have no permissions to remove it.

@cewood
Copy link

cewood commented Nov 8, 2023

Seems related to API changes that DNSimple seems to have made a some point, and we discovered as part of https://github.com/protocol/bifrost-infra/issues/2814 and ipfs-shipyard/dnslink-dnsimple#21

@hacdias
Copy link
Member

hacdias commented Nov 8, 2023 •
edited
Loading

We'll need to also update https://github.com/ipfs-shipyard/js-dnslink-dnsimple then (which after a npm-check-updates is very out of date 😱 )

@lidel lidel added the P0 Critical: Tackled by core team ASAP label Nov 8, 2023
@lidel
Copy link
Member Author

lidel commented Nov 8, 2023 •
edited
Loading

Asked @olizilla to give me and @hacdias publishing rights to the NPM package, but JS necromancy can be a time sink.
Switching to already working and way more deterministic GO version may be more stable, given how finicky JS packages run via npx can be.

I'll open a PR later today. Update: see #1055

@lidel lidel mentioned this issue Nov 8, 2023
Merged
4 tasks
lidel added a commit to ipfs/ipfs-webui that referenced this issue Nov 9, 2023
@lidel
fix: switch to new dnslink updater
ff6d87a 
This solves problem described in ipfs/distributions#1053
by switching to new tool like we did in ipfs/distributions#1055
@lidel lidel mentioned this issue Nov 9, 2023
Merged
@BigLep BigLep mentioned this issue Nov 9, 2023
Closed
11 tasks
lidel added a commit to ipfs/ipfs-webui that referenced this issue Nov 9, 2023
@lidel
fix: switch to new dnslink updater (#2175)
a63f48a 
This solves problem described in ipfs/distributions#1053
by switching to new tool like we did in ipfs/distributions#1055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: switch to new dnslink updater ipfs/distributions
3 participants
@lidel @cewood @hacdias