Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(angular): migrate deprecated RouterTestingModule #1843

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

sean-perkins
Copy link
Contributor

RouterTestingModule was deprecated in v17.3.0 of Angular and marked as deprecate here: angular/angular#54466

@sean-perkins sean-perkins marked this pull request as ready for review April 24, 2024 20:19
@sean-perkins sean-perkins requested a review from a team as a code owner April 24, 2024 20:19
@sean-perkins sean-perkins requested review from brandyscarney and removed request for a team April 24, 2024 20:19
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sean-perkins sean-perkins merged commit 0585aca into main Apr 25, 2024
30 checks passed
@sean-perkins sean-perkins deleted the sp/router-testing-module branch April 25, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants