Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python2 support #8

Merged
merged 5 commits into from
Jun 18, 2020
Merged

Python2 support #8

merged 5 commits into from
Jun 18, 2020

Conversation

MeitarR
Copy link
Contributor

@MeitarR MeitarR commented Jun 18, 2020

solves #3

as I wrote at the last commit, I"m not sure that asyncio is needed at all but I can"t check that as I don"t have Ida with python 3 support. It will be better if someone will check that before its merged.

tested on IDA 7.0 and python 2: executing and debugging works.

@ioncodes
Copy link
Owner

Thanks for the PR! I"ll have a look at it.

@ioncodes
Copy link
Owner

asyncio seems to be required for Python 3. Well done with the PR, it works flawlessly from what I can tell. Is there a specific reason why you added a __init__.py?

@MeitarR
Copy link
Contributor Author

MeitarR commented Jun 18, 2020

asyncio seems to be required for Python 3. Well done with the PR, it works flawlessly from what I can tell. Is there a specific reason why you added a __init__.py?

without it I get the error

C:\Program Files\IDA 7.0\plugins\idacode.py: No module named idacode_utils.plugin
Traceback (most recent call last):
  File "C:\Program Files\IDA 7.0\python\ida_idaapi.py", line 553, in IDAPython_ExecScript
    execfile(script, g)
  File "C:/Program Files/IDA 7.0/plugins/idacode.py", line 6, in <module>
    import idacode_utils.plugin as plugin
ImportError: No module named idacode_utils.plugin

because its not a module

@ioncodes
Copy link
Owner

Interesting! That seems to be an issue with IDA 7.0 specifically, I wasn"t aware of this. I can"t trigger that issue with IDA 7.2 and IDA 7.4. Nice catch! I"ll update a few things in this PR to get things ready for a new release :)

@ioncodes ioncodes merged commit f0e64b0 into ioncodes:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants