Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a non-breaking change, affecting only TypeScript types, and doesn't change the implementation in any way.
Motivation
inversify
already has some basic support for types when binding, and retrieving bindings.However, the type support requires manual intervention from developers, and can be error-prone.
For example, the following code will happily compile, even though the types here are inconsistent:
Furthermore, this proposal paves the way for type-safe injection, which will be added once this change is in.
Improved type safety
This change adds an optional type parameter to the
Container
, which takes an identifier map as an argument. For example:If a
Container
is typed like this, we now get strong typing both when binding, and getting bindings:This also has the added benefit of no longer needing to pass around service identifier constants: the strings (or symbols) are all strongly typed, and will fail compilation if an incorrect one is used.
Non-breaking
This change aims to make no breaks to the existing types, so any
Container
without an argument should continue to work as it did before.Related Issue
#788
How Has This Been Tested?
Types of changes
Checklist: