Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24-bit True Color #23

Open
lisdude opened this issue Nov 4, 2018 · 3 comments
Open

24-bit True Color #23

lisdude opened this issue Nov 4, 2018 · 3 comments

Comments

@lisdude
Copy link

lisdude commented Nov 4, 2018

The final great enhancement, I think, would be adding true color support. Sadly I have no idea where to even start to attempt to do it myself.

@ingwarsw
Copy link
Owner

@lisdude Im not sure how hard would be to add that too..
And Im not sure if it would help a lot..

With such small "resolution" 256 colours seems enough..

But maybe someone could make it true..

@lotheac
Copy link
Contributor

lotheac commented Oct 19, 2020

I have experimental 24-bit color support in my fork -- passthrough to terminal only, they are not available as tf attrs. But this should give an idea of what is involved if someone wants to implement 'real' support.

bat-boys@0c1d9f3 attr_t is too small, so it needs to be first made bigger to accommodate for an additional 24 bits of color information.
bat-boys@dea488a then the state machine for color code parsing needs to be expanded a bit. NOTE: this only supports the "38;2;R;G;B" form, which seems to be the most commonly supported one in terminals, but AFAIK nonstandard.

edit: apparently I did add support for other forms of the 24bit escapes as well, but forgot about it already. bat-boys@48a52f5

@warmstarter
Copy link
Contributor

I'm curious about what you have going on here and what issues you see existing and what needs to be done. I know of at least on well known server that would likely implement 24bit/True color if the TinyFugue had such a feature available.

I know TinyMUX 2 currentl has 24bit color support and they have a public server where the devs hang out. Could be a good palce to look into regarding how they implemented it and what would need to be compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants