Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline empty state improvements #1395

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Conversation

carlinisaacson
Copy link
Member

#1359

  • Timeline empty state improvements
    • Adds a button for the quick start guide
    • Adds a random developer joke

Contributors: @carlinisaacson @trevor-coleman @darinwilson

DD321274-A94C-42AF-BCAF-AB9A6996B126

Copy link
Member

@robinheinze robinheinze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Just left one question :)

Copy link
Contributor

@morganick morganick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 and works as expected.

Note: The screenshot on the docs needs to be updated: https://docs.infinite.red/reactotron/quick-start/react-native/

@frankcalise frankcalise linked an issue Oct 9, 2024 that may be closed by this pull request
Copy link
Contributor

@frankcalise frankcalise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated with latest from main

@frankcalise frankcalise merged commit f1472d7 into master Oct 17, 2024
2 checks passed
@frankcalise frankcalise deleted the feat/empty-state-improvements branch October 17, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Jokes in the timeline
4 participants