Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tropical and sidereal times #182

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Add tropical and sidereal times #182

merged 1 commit into from
Apr 24, 2020

Conversation

Aehmlo
Copy link
Contributor

@Aehmlo Aehmlo commented Apr 23, 2020

No description provided.

iliekturtles
iliekturtles reviewed Apr 23, 2020
View reviewed changes
Copy link
Owner

@iliekturtles iliekturtles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR!

Based on the NIST 811 reference I think sidereal and tropical should be parenthetical "day (sidereal)", but do you have any other reference? Same for the abbreviations "d (sidereal)".

@Aehmlo
Copy link
Contributor Author

Aehmlo commented Apr 23, 2020

I haven't found much consistency in the abbreviations used, so I've gone ahead and changed it to the parenthetical style, since that seems like a good compromise.

@iliekturtles iliekturtles merged commit ca44b49 into iliekturtles:master Apr 24, 2020
@iliekturtles
Copy link
Owner

Thanks again! Merged.

@iliekturtles iliekturtles mentioned this pull request Apr 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliekturtles iliekturtles iliekturtles left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aehmlo @iliekturtles