Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code for supporting 10.11 - 10.14 systems #5085

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

uiryuu
Copy link
Member

@uiryuu uiryuu commented Jul 23, 2024


Description:
This is a redo of #4977. Changes in the source code are straightforward. There are a few changes in xib files:

  • Removed an image view in AboutWindowController, which is used to set a mask image for systems prior to 10.14
  • Removed "Medium Light" and "Ultra Dark" menu items in PrefUIViewController

// Once macOS 10.11 is no longer supported the contents of the method can be inlined in this
// closure.
self.shutdownTimedout()
let timer = Timer(timeInterval: terminationTimeout, repeats: false) { _ in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a [unowned self] here?

@uiryuu uiryuu merged commit 92bdc05 into develop Aug 1, 2024
1 check passed
@uiryuu uiryuu deleted the remove-old-code branch August 1, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants