Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to limit toggle PIP on minimize/unminimize to video only #5068

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ShlomoCode
Copy link
Contributor

@ShlomoCode ShlomoCode commented Jul 13, 2024

@ShlomoCode ShlomoCode changed the title feat: add option to limit toggle PIP on minimize/unminimize to video … feat: add option to limit toggle PIP on minimize/unminimize to video only Jul 13, 2024
@ShlomoCode ShlomoCode force-pushed the feature/pip-limit-toggle-to-video branch from 2289239 to 733c3f9 Compare July 14, 2024 19:08
@ShlomoCode
Copy link
Contributor Author

I struggled for a long time with the interface builder but I couldn't figure out how to create the constraints properly... @low-batt, maybe you can do that please?
Besides that, the PR seems to me to be ready.

@ShlomoCode ShlomoCode marked this pull request as ready for review July 14, 2024 19:12
@low-batt
Copy link
Contributor

I will take a look at this soon. Need to finish up two PRs I'm in the middle of at the moment.

@svobs
Copy link
Contributor

svobs commented Jul 18, 2024

I struggled for a long time with the interface builder but I couldn't figure out how to create the constraints properly...

@ShlomoCode I went ahead and did it. Take a look at bdb3c2a.

I couldn't figure out a way to submit an update to this PR directly, but feel free to copy & paste it into your code or whatever. I don't need attribution for it.

@svobs
Copy link
Contributor

svobs commented Jul 18, 2024

Forgot to add: to add logic to gray out the property when its "parent" (togglePipByMinimizingWindow) is unchecked:
SCR-20240717-ukvh

@ShlomoCode
Copy link
Contributor Author

ShlomoCode commented Jul 18, 2024

@svobs Thank you! I just added a .patch at the end (https://github.com/iina/iina/commit/bdb3c2a84ed1b64e9309f39837be0c6a87df9df8.patch) and then saved to a file, run git apply and pushed.

@ShlomoCode
Copy link
Contributor Author

I think this PR is ready

@ShlomoCode ShlomoCode force-pushed the feature/pip-limit-toggle-to-video branch from 7b96815 to a391709 Compare July 18, 2024 11:58
@ShlomoCode
Copy link
Contributor Author

@uiryuu @CarterLi How can we continue with this?

@ShlomoCode ShlomoCode force-pushed the feature/pip-limit-toggle-to-video branch from a391709 to 8a7cb52 Compare July 26, 2024 14:11
@uiryuu
Copy link
Member

uiryuu commented Jul 27, 2024

Please be patient :) We are currently dealing with the remining issues for the first beta of 1.4.0 release. This PR will be included in the second beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to limit "PIP toggle on minimize/unminimizing" to video files only
4 participants