Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install the plugin by opening the .iinaplugin file in Finder or using URL Scheme #4403

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Install the plugin by opening the .iinaplugin file in Finder or using URL Scheme #4403

wants to merge 12 commits into from

Conversation

xjbeta
Copy link
Contributor

@xjbeta xjbeta commented May 9, 2023

Description:

  • Installing plugin when open '.iinaplgz' file in Finder
  • Installing plugin with URL Scheme

low-batt
low-batt reviewed May 12, 2023
View reviewed changes
iina/AppDelegate.swift Outdated Show resolved Hide resolved
low-batt
low-batt reviewed May 12, 2023
View reviewed changes
iina/AppDelegate.swift Outdated Show resolved Hide resolved
low-batt
low-batt reviewed May 12, 2023
View reviewed changes
iina/Utility.swift Outdated Show resolved Hide resolved
@low-batt low-batt requested a review from lhc70000 May 12, 2023 03:10
@low-batt
Copy link
Contributor

I pulled the PR, built IINA and then installed it into Applications so Finder would use it and enabled the plugin system.

I created an iinaplgz file by zipping up plugin-online-media. Double clicking brought up IINA and installed the plugin. However the plugin was not listed under Plugins in settings until IINA was restarted. This is not the case when I installed using the Install from a local package….

With IINA shutdown when I clicked on the plugin again in Finder, IINA put up this message:
pr-4403-update

This is actually better than what happens if you use the Install from a local package… button. That method installs a duplicate of the same plugin (an existing issue not related to the changes in this PR). Still it would be nice if IINA recognized this plugin was already installed and asked if you wanted to reinstall.

After clicking OK IINA put up this message:
pr-4403-permissions

With an empty list of permissions to review. I clicked on Install. I then went into settings - Plugins, clicked on the plugin and then clicked Uninstall. IINA crashed:

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   libswiftCore.dylib            	       0x1a691490c closure #1 in closure #1 in closure #1 in _assertionFailure(_:_:file:line:flags:)   308
1   libswiftCore.dylib            	       0x1a6914790 closure #1 in closure #1 in _assertionFailure(_:_:file:line:flags:)   344
2   libswiftCore.dylib            	       0x1a691410c _assertionFailure(_:_:file:line:flags:)   188
3   IINA                          	       0x10296ec58 JavascriptAPIS
[JavascriptAPISidebarView-crash.txt](https://github.com/iina/iina/files/11468271/JavascriptAPISidebarView-crash.txt)
idebarVie
[JavascriptAPISidebarView-crash.txt](https://github.com/iina/iina/files/11468272/JavascriptAPISidebarView-crash.txt)
w.cleanUp(_:)   668 
[JavascriptAPISidebarView-crash.txt](https://github.com/iina/iina/files/11468280/JavascriptAPISidebarView-crash.txt)
(JavascriptAPISidebarView.swift:26)
4   IINA                          	       0x1029f156c closure #1 in JavascriptPluginInstance.deinit   84 (JavascriptPluginInstance.swift:73)
5   IINA                          	       0x1029f4514 partial apply for closure #1 in JavascriptPluginInstance.deinit   20
6   libswiftCore.dylib            	       0x1a69aebd0 Sequence.forEach(_:)   688
7   IINA                          	       0x1029f144c JavascriptPluginInstance.deinit   852 (JavascriptPluginInstance.swift:73)
8   IINA                          	       0x1029f159c JavascriptPluginInstance.__deallocating_deinit   28

Full crash report:
JavascriptAPISidebarView-crash.txt

Not sure how much of this is due to existing plugin problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@low-batt low-batt low-batt left review comments

@lhc70000 lhc70000 Awaiting requested review from lhc70000

Assignees
No one assigned
Labels
feature: plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xjbeta @low-batt @uiryuu