Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide python2.7 virtual environment for iiab apps #2034

Closed
wants to merge 10 commits into from

Conversation

jvonau
Copy link
Contributor

@jvonau jvonau commented Nov 10, 2019

Keeps current python2.7 apps contained in virtualenv till porting can be completed, step to solve #2013 as the dependencies supplied by pip are in flux pending review and testing.

@holta holta added this to the 7.1 milestone Nov 10, 2019
@holta
Copy link
Member

holta commented Nov 10, 2019

Ref: #1810

@jvonau
Copy link
Contributor Author

jvonau commented Nov 22, 2019

iiab-make-kiwix-lib.py iiab-update-maps ported to python3

@holta
Copy link
Member

holta commented Nov 22, 2019

@georgejhunt can you please review this now?

@jvonau @tim-moody what smoke/functional tests are most needed here?

@georgejhunt
Copy link
Contributor

Adam asked me to review this.
I don't understand what problem this is trying to solve.
If it is just geojson, I think this is overkill.
I think Tim has said that he has all his code running under py3

@georgejhunt
Copy link
Contributor

And as I read more, trying to educate myself about uWSGI and python3, it seems that many suggest that all significant programs should be housed in a venv.
So if Tim's ok with it, since I don't know any different, I'm fine with #2034;
But don't we want to be shooting for py3 in the long term? Should we take the time now to get it running on py3?

@georgejhunt
Copy link
Contributor

I have succeeded in getting admin-console running on #2034
Change uwsgi to:
[uwsgi]
uid = www-data
gid = www-data
socket = /tmp/admin-console.sock
chdir = /opt/admin/console
wsgi-file = cmd-service.wsgi
master = true
plugins = python3 <=====
change uwsgi.unit to:
[Unit]
Description=uWSGI Service

[Service]
ExecStart=/usr/bin/uwsgi --ini /etc/uwsgi/apps-enabled/admin-console.ini <====
Restart=always
RestartSec=5
KillSignal=SIGQUIT
Type=notify
NotifyAccess=all

[Install]
WantedBy=multi-user.target

@holta holta requested a review from tim-moody November 22, 2019 23:43
@jvonau
Copy link
Contributor Author

jvonau commented Nov 23, 2019

Wrong PR but I'll continue here to sum up the sequence of events, Tim asked for 0b0014d but didn't provide the file in 263. Placing the file as need with the above edit results in a working admin-console backend on U-19.10 as 2042 does not address moving to python3 directly but is careful not to add python2 as a dependency.

@georgejhunt
Copy link
Contributor

georgejhunt commented Nov 23, 2019 via email

@jvonau
Copy link
Contributor Author

jvonau commented Nov 23, 2019

Are you wanting to run admin-console under py2.7? If so why? Which iiab apps do you think require py2.7?

Wrong PR, but when I started out there was no activity to port to python3 and Ubuntu-19.10 was failing due to python2 dependencies. Today it looks like the only thing left to port to python3 is captive-portal which I didn't address directly because the backend is Apache but your original PR never dealt with, but can provide a virtualenv to run python2 in for captive-portal to run in.

@georgejhunt
Copy link
Contributor

georgejhunt commented Nov 23, 2019 via email

@jvonau
Copy link
Contributor Author

jvonau commented Nov 25, 2019

replaced by 2048

@jvonau jvonau closed this Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants