-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide python2.7 virtual environment for iiab apps #2034
Conversation
Ref: #1810 |
74880da
to
1d90322
Compare
iiab-make-kiwix-lib.py iiab-update-maps ported to python3 |
@georgejhunt can you please review this now? @jvonau @tim-moody what smoke/functional tests are most needed here? |
Adam asked me to review this. |
And as I read more, trying to educate myself about uWSGI and python3, it seems that many suggest that all significant programs should be housed in a venv. |
I have succeeded in getting admin-console running on #2034 [Service] [Install] |
Wrong PR but I'll continue here to sum up the sequence of events, Tim asked for 0b0014d but didn't provide the file in 263. Placing the file as need with the above edit results in a working admin-console backend on U-19.10 as 2042 does not address moving to python3 directly but is careful not to add python2 as a dependency. |
Are you wanting to run admin-console under py2.7? If so why? Which iiab
apps do you think require py2.7?
…On Sat, Nov 23, 2019 at 2:03 AM Jerry Vonau ***@***.***> wrote:
Wrong PR but I'll continue here to sum up the sequence of events, Tim
asked for 0b0014d
<0b0014d>
but didn't provide the file in 263. Placing the file as need with the above
edit results in a working admin-console backend on U-19.10 as 2042 does not
address moving to python3 directly but is careful not to add python2 as a
dependency.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2034?email_source=notifications&email_token=AAOTQHDDA2RPPYFTR3RQWV3QVDITRA5CNFSM4JLLBZF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE7PGRY#issuecomment-557773639>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOTQHB6HVDFYPCVRREQ7HLQVDITRANCNFSM4JLLBZFQ>
.
|
Wrong PR, but when I started out there was no activity to port to python3 and Ubuntu-19.10 was failing due to python2 dependencies. Today it looks like the only thing left to port to python3 is captive-portal which I didn't address directly because the backend is Apache but your original PR never dealt with, but can provide a virtualenv to run python2 in for captive-portal to run in. |
I've verified that captive portal does not error out under python3. But I
don't currently have the ability to test all the clients against py3, and
verify function.
…On Sat, Nov 23, 2019 at 8:16 AM Jerry Vonau ***@***.***> wrote:
Are you wanting to run admin-console under py2.7? If so why? Which iiab
apps do you think require py2.7?
Wrong PR, but when I started out there was no activity to port to python3
and Ubuntu-19.10 was failing due to python2 dependencies. Today it looks
like the only thing left to port to python3 is captive-portal which I
didn't address directly because the backend is Apache but your original PR
never dealt with but can provide a virtualenv to run python2 in for
captive-portal to run in.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2034?email_source=notifications&email_token=AAOTQHFYO3MYWHUK3LJN3A3QVEUJ7A5CNFSM4JLLBZF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE7U6UI#issuecomment-557797201>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOTQHFIKAP2OK4W6ZFTVHDQVEUJ7ANCNFSM4JLLBZFQ>
.
|
replaced by 2048 |
Keeps current python2.7 apps contained in virtualenv till porting can be completed, step to solve #2013 as the dependencies supplied by pip are in flux pending review and testing.