Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the LSN indicated in the server heartbeat was not used to in the status reply, leading to the logical replication being delayed at least by 1 change. The issue did not have an impact on the data being received from the replication but it was an issue when trying to stop the PostgreSQL server, as it will wait for the replication to be up to date before shutting down.
In my case, it prevented the PostgreSQL server to shut down completely, which is not great in a HA fashion.
The issue can be easily reproduced by starting this project and noticing on PostgreSQL using
select * from pg_stat_replication;
that thesent_lsn
andwrite_lsn
differs. Also trying to shut down usingpg_ctl
will lead to apg_ctl: server does not shut down
unlesswal-listener
is stopped in between.This commits is inspired by what is done in the
pglogrepl
project (which is the "replication" part ofpgx
), in the logical replication example : https://github.com/jackc/pglogrepl/blob/master/example/pglogrepl_demo/main.go#L128