Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LSN not correctly updated #43

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

StephenSorriaux
Copy link
Contributor

Before this change, the LSN indicated in the server heartbeat was not used to in the status reply, leading to the logical replication being delayed at least by 1 change. The issue did not have an impact on the data being received from the replication but it was an issue when trying to stop the PostgreSQL server, as it will wait for the replication to be up to date before shutting down.

In my case, it prevented the PostgreSQL server to shut down completely, which is not great in a HA fashion.

The issue can be easily reproduced by starting this project and noticing on PostgreSQL using select * from pg_stat_replication; that the sent_lsn and write_lsn differs. Also trying to shut down using pg_ctl will lead to a pg_ctl: server does not shut down unless wal-listener is stopped in between.

This commits is inspired by what is done in the pglogrepl project (which is the "replication" part of pgx), in the logical replication example : https://github.com/jackc/pglogrepl/blob/master/example/pglogrepl_demo/main.go#L128

Before this change, the LSN indicated in the server heartbeat was not used to in the status reply, leading to the logical replication being delayed at least by 1 change. The issue did not have an impact on the data being received from the replication but it was an issue when trying to stop the PostgreSQL server, as it will wait for the replication to be up to date before shutting down.
@ihippik
Copy link
Owner

ihippik commented Sep 19, 2024

Thank you @StephenSorriaux , i will check soon!

@ihippik ihippik merged commit e3a332b into ihippik:master Sep 19, 2024
@StephenSorriaux StephenSorriaux deleted the fix/lsn-heartbeat branch December 19, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants