Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix environment variable handling in config provider #629

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix environment variable handling in config provider #629

merged 2 commits into from
Feb 1, 2024

Conversation

hubcio
Copy link
Collaborator

@hubcio hubcio commented Jan 31, 2024 •
edited
Loading

  • Remove unused import from integration tests
  • Refactor env var setting in tests for clarity
  • Correct assertions to match refactored test variables
  • Implement keys_to_env_key function for env var mapping
  • Enhance insert_overridden_values_from_env to handle nested keys
  • Add debug logging for improved traceability in CustomEnvProvider
  • Remove obsolete env var removals in tests

Closes #624.

@hubcio hubcio changed the title FFix environment variable handling in config provider Fix environment variable handling in config provider Jan 31, 2024
@hubcio hubcio force-pushed the fix_config_provider branch 3 times, most recently from 520dbed to ae246ba Compare January 31, 2024 21:46
@hubcio
Fix environment variable handling in config provider
9171510 
- Remove unused import from integration tests
- Refactor env var setting in tests for clarity
- Correct assertions to match refactored test variables
- Implement keys_to_env_key function for env var mapping
- Enhance insert_overridden_values_from_env to handle nested keys
- Add debug logging for improved traceability in CustomEnvProvider
- Remove obsolete env var removals in tests
@hubcio hubcio force-pushed the fix_config_provider branch from ae246ba to 9171510 Compare January 31, 2024 21:47
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (9975c8a) 74.47% compared to head (28343aa) 74.47%.

Files Patch % Lines
server/src/configs/config_provider.rs 69.56% 3 Missing and 4 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #629    /-   ##
=======================================
  Coverage   74.47%   74.47%           
=======================================
  Files         316      316           
  Lines       23992    24000     8     
  Branches    23992    24000     8     
=======================================
  Hits        17869    17875     6     
- Misses       4330     4332     2     
  Partials     1793     1793

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spetz spetz merged commit 554d06e into master Feb 1, 2024
15 checks passed
@spetz spetz deleted the fix_config_provider branch February 1, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spetz spetz spetz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix environment variable configuration for snake_case names
2 participants
@hubcio @spetz