Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing trims to GetMasterHostPort and remove Convert.ToString from variables that are strings already #5730

Conversation

N-o-X
Copy link
Contributor

@N-o-X N-o-X commented Nov 8, 2017

refs #5705

Copy link
Contributor

@dnsmichi dnsmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! 💪

args = " --master_host " Convert.ToString(master_host).Trim()
"," Convert.ToString(master_port).Trim();
args = " --master_host " master_host.Trim()
"," master_port.Trim();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that you're calling Trim() on the strings that were returned by GetMasterHostPort(). That's not strictly necessary, because you're already calling Trim() in that function.

@gunnarbeutner gunnarbeutner modified the milestones: 2.9.0, 2.8.0 Nov 9, 2017
@N-o-X N-o-X force-pushed the fix/trim-form-fields-to-avoid-hidden-crlf-characters-from-linux-5705 branch from 3f04eb5 to 22bde1e Compare November 9, 2017 08:21
@N-o-X N-o-X force-pushed the fix/trim-form-fields-to-avoid-hidden-crlf-characters-from-linux-5705 branch from 22bde1e to 4579e8f Compare November 9, 2017 08:28
@gunnarbeutner gunnarbeutner merged commit bcf6739 into master Nov 9, 2017
@N-o-X N-o-X deleted the fix/trim-form-fields-to-avoid-hidden-crlf-characters-from-linux-5705 branch November 16, 2017 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants