Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10211] PerfdataValue is not properly serialised in status queries #3434

Closed
icinga-migration opened this issue Sep 24, 2015 · 6 comments
Labels
area/api REST API bug Something isn't working
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10211

Created by mfriedrich on 2015-09-24 11:24:02 00:00

Assignee: gbeutner
Status: Resolved (closed on 2015-09-29 08:49:44 00:00)
Target Version: 2.4.0
Last Update: 2015-09-30 16:29:10 00:00 (in Redmine)

Icinga Version: 2.4.0
Backport?: No
Include in Changelog: 0

"LivestatusListener": {
"perfdata": [
null
],
"status": {
"livestatuslistener": {
"livestatus": {
"connections": 3
}
}
}
},

Changesets

2015-09-28 12:37:50 00:00 by (unknown) f091379

Fix: PerfdataValue is not properly serialised in status queries

fixes #10211
@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-24 16:53:07 00:00

When using PerfdataValue->Format for proper serialisation, we'll run into the problem that PerfdataValue is part of libicinga, but not libbase. We can't link to libicinga from libremote. It would make sense to move the PerfdataValue class to libbers then.

@icinga-migration
Copy link
Author

Updated by gbeutner on 2015-09-28 12:38:10 00:00

  • Assigned to changed from jflach to gbeutner

@icinga-migration
Copy link
Author

Updated by Anonymous on 2015-09-28 12:40:03 00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset f091379.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-28 16:31:24 00:00

  • Status changed from Resolved to Assigned

We'll now have a different format for performance data. The check result output in checkable objects provides the formatted string

"performance_data": [
"rta=4.893000ms;3000.000000;5000.000000;0.000000",
"pl=0%;80;100;0"
],

while the status perfdata looks different

"perfdata": [
{
"counter": false,
"crit": null,
"label": "checkercomponent_checker_idle",
"max": null,
"min": null,
"type": "PerfdataValue",
"unit": "",
"value": 18,
"warn": null
},
{
"counter": false,
"crit": null,
"label": "checkercomponent_checker_pending",
"max": null,
"min": null,
"type": "PerfdataValue",
"unit": "",
"value": 0,
"warn": null
}
],

Imho we should find a unique way to display performance data, either one or the other.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-29 08:49:44 00:00

  • Status changed from Assigned to Resolved

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-30 16:29:10 00:00

  • Backport? changed from TBD to No

@icinga-migration icinga-migration added bug Something isn't working area/api REST API labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.4.0 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api REST API bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant