Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #6773] Order doesn't work in check ssh command #1821

Closed
icinga-migration opened this issue Jul 21, 2014 · 5 comments
Closed
Labels
area/itl Template Library CheckCommands bug Something isn't working
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/6773

Created by ccesario on 2014-07-21 13:07:00 00:00

Assignee: gbeutner
Status: Resolved (closed on 2014-07-21 13:09:39 00:00)
Target Version: 2.0.2
Last Update: 2014-07-28 10:13:04 00:00 (in Redmine)

Icinga Version: v2.0.1-13-g5436256

Check ssh command argument order are not working. After the last upgrade the check_ssh commands stopped to work.

Log

[2014-07-18 17:59:55 -0300] notice/Process: Running command '/usr/lib/nagios/plugins/check_ssh', '192.168.15.1', '-p', '22': PID 25850

The argument -p needs to be first according command.

Wrong

# /usr/lib/nagios/plugins/check_ssh 192.168.15.1 -p 22
Usage:
check_ssh [-46] [-t ] [-r ] [-p ] 

Correct

# /usr/lib/nagios/plugins/check_ssh -p 22 192.168.15.1
SSH OK - XXXX (protocol 2.0)

Version

# icinga2 -V
icinga2 - The Icinga 2 network monitoring daemon. (Version: v2.0.1-13-g5436256)

# /usr/lib/nagios/plugins/check_ssh  --version
check_ssh v1.4.15 (nagios-plugins 1.4.15)

Command definition

object CheckCommand "ssh" {
    import "plugin-check-command"

    command = [ PluginDir   "/check_ssh" ]

    arguments = {
        "-p" = "$ssh_port$"
        "host" = {
            value = "$ssh_address$"
            skip_key = true
            order = -1
        }
    }

    vars.ssh_address = "$address$"
}

Changesets

2014-07-21 13:09:01 00:00 by gbeutner abc3869

Fix order attribute for the ssh check command

fixes #6773

Relations:

@icinga-migration
Copy link
Author

Updated by gbeutner on 2014-07-21 13:09:39 00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset abc3869.

@icinga-migration
Copy link
Author

Updated by gbeutner on 2014-07-21 13:10:48 00:00

  • Category set to ITL
  • Assigned to set to gbeutner
  • Target Version set to 2.0.2

@icinga-migration
Copy link
Author

Updated by gbeutner on 2014-07-21 13:11:02 00:00

  • Subject changed from Order doesn't working in check ssh command to Order doesn't work in check ssh command

@icinga-migration
Copy link
Author

Updated by ccesario on 2014-07-21 13:42:16 00:00

It is fixed!

Thanks!

@icinga-migration
Copy link
Author

Updated by tobiasvdk on 2014-07-28 10:13:04 00:00

Are negative numbers not allowed for order?

@icinga-migration icinga-migration added bug Something isn't working area/itl Template Library CheckCommands labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.0.2 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/itl Template Library CheckCommands bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant