Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #6646] NULL vs empty string #1757

Closed
icinga-migration opened this issue Jul 4, 2014 · 9 comments
Closed

[dev.icinga.com #6646] NULL vs empty string #1757

icinga-migration opened this issue Jul 4, 2014 · 9 comments
Labels
area/db-ido Database output blocker Blocks a release or needs immediate attention bug Something isn't working
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/6646

Created by tgelf on 2014-07-04 15:43:24 00:00

Assignee: gbeutner
Status: Resolved (closed on 2014-07-23 08:30:05 00:00)
Target Version: 2.0.2
Last Update: 2014-09-16 09:19:50 00:00 (in Redmine)

Icinga Version: 2.0.0

The icinga_objects table has to show NULL for name2 if there is no such property, not an empty string. The column is 'DEFAULT NULL', "" is just wrong here. I guess a lot of people have built queries based on this, I definitively did. And as far as I remember also the default Icinga Jasper reports do.

Cheers,
Thomas

Changesets

2014-07-22 08:29:09 00:00 by gbeutner f86068d

Use NULL instead of empty strings for name2 in the icinga_objects table

fixes #6646

2014-07-23 08:25:26 00:00 by gbeutner 1a361d8

Add MySQL/pgSQL upgrade files which fix name2 in the icinga_objects table

fixes #6646

2014-07-23 08:48:33 00:00 by (unknown) 88d1081

Rename upgrade sql files

refs #6646
@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-07-06 10:00:38 00:00

  • Priority changed from Normal to High
  • Target Version set to 2.0.1

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-07-09 15:04:35 00:00

  • Target Version deleted 2.0.1

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-07-10 15:19:05 00:00

  • Target Version set to 2.0.2

@icinga-migration
Copy link
Author

Updated by gbeutner on 2014-07-11 09:23:31 00:00

  • Estimated Hours set to 8

Required changes:

  • Update db_ido to support default values (by removing columns with empty values)

@icinga-migration
Copy link
Author

Updated by gbeutner on 2014-07-22 08:21:44 00:00

  • Assigned to set to gbeutner

I'm limiting the scope of the change to the icinga_objects table so as to not break other tables which might not have default values for some of their columns. What this means is that after this is fixed new rows in the icinga_objects table should have name2 set to whatever is the default value for that column (apparently NULL atm).

@icinga-migration
Copy link
Author

Updated by gbeutner on 2014-07-22 08:30:04 00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset i2:f86068d5e089b75b4b1bafe31829d9992d26d1ad.

@icinga-migration
Copy link
Author

Updated by tgelf on 2014-07-22 10:51:56 00:00

  • Status changed from Resolved to Assigned

Please also take care of "dirty" tables for existing Icinga 2.0 stable setups.

Thanks,
Thomas

@icinga-migration
Copy link
Author

Updated by gbeutner on 2014-07-23 08:30:05 00:00

  • Status changed from Assigned to Resolved

Applied in changeset i2:1a361d834ade415957a6b7f7f38e206786365009.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-09-16 09:19:50 00:00

  • Project changed from 32 to Icinga 2
  • Category set to DB IDO

@icinga-migration icinga-migration added blocker Blocks a release or needs immediate attention bug Something isn't working area/db-ido Database output labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.0.2 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/db-ido Database output blocker Blocks a release or needs immediate attention bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant