-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev.icinga.com #6549] GraphiteWriter regularly sends empty lines #1722
Comments
Updated by gbeutner on 2014-06-24 10:08:34 00:00 GraphiteWriter::ReconnectTimerHandler is sending an empty line every 10 seconds to check if the Graphite socket is still connected. I guess what we could do is: a) Decrease the interval |
Updated by gvegidy on 2014-06-24 11:12:27 00:00 Hmm. Why do we care if the socket is still connected if we are not sending data? When we want to send actual data and that fails, we should have code in place to resend, reconnect and so on. So why try to find out that the socket is disconnected beforehand? Can't we just rely on the failure handling code? |
Updated by mfriedrich on 2014-07-10 15:22:15 00:00
|
Updated by gbeutner on 2014-07-11 07:44:16 00:00 We'd be losing performance data when the socket is not connected. |
Updated by gbeutner on 2014-07-11 08:31:26 00:00
|
Updated by gbeutner on 2014-07-11 09:01:11 00:00
Required changes:
|
Updated by gvegidy on 2014-07-11 10:35:45 00:00 gunnarbeutner wrote:
When we try to send data and get an error back we should retry, reconnect and so on. This is the same we can do when we see a problem with the current interval checking. We can not rely on finding out that the socket is gone beforehand, otherwise there will always be a short interval in which we would lose data. If the error handling code is reliable, we don't need interval checking. So what can the interval checking do better then a good error handling routine? Why would we not lose data with the interval checking what a good error handler would have lost? |
Updated by gbeutner on 2014-08-06 08:00:36 00:00
Applied in changeset 089fdb1. |
This issue has been migrated from Redmine: https://dev.icinga.com/issues/6549
Created by gvegidy on 2014-06-23 23:53:19 00:00
Assignee: (none)
Status: Resolved (closed on 2014-08-06 08:00:36 00:00)
Target Version: 2.0.2
Last Update: 2014-08-06 08:00:36 00:00 (in Redmine)
when the GraphiteWriter is enabled, carbon-cache complains like this every few seconds (listener.log):
I have added some debugging and it seems like GraphiteWriter is sending an empty line.
When looking at the icinga debug log, I do not see an emtpy line announced with the regular "debug/GraphiteWriter: GraphiteWriter: Add to metric list: ...".
But it seems like the complaints of carbon-cache correlate to these messages in the icinga log:
Changesets
2014-08-06 07:59:38 00:00 by gbeutner 089fdb1
The text was updated successfully, but these errors were encountered: