Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icestark): fix isAssetExist type statement #525

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

1ncounter
Copy link
Contributor

Modify the isAssetExist function parameter element type to HTMLScriptElement | HTMLLinkElement

@maoxiaoke maoxiaoke changed the base branch from master to release/2.7.2 February 11, 2022 06:43
@maoxiaoke maoxiaoke merged commit 6ac6b1c into ice-lab:release/2.7.2 Feb 11, 2022
@maoxiaoke maoxiaoke mentioned this pull request Feb 11, 2022
2 tasks
maoxiaoke added a commit that referenced this pull request Mar 24, 2022
* fix(icestark): fix isAssetExist type statement (#525)
* fix: 🐛 set actual basename when `activePath` is an array (#529)

✅ Closes: #526

Co-authored-by: 1ncounter <[email protected]>
Co-authored-by: 唐澜 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants