Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update parser to support multiple fallback keys #251

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Update parser to support multiple fallback keys #251

merged 4 commits into from
Aug 21, 2023

Conversation

scottgonzalez
Copy link
Contributor

  • Update parser to support fallback keys via t(['key1', 'key2']).
  • Fix regex escape for function names.

Note: I had to remove acorn-dynamic-import as it is no longer supported and is incompatible with newer versions of acorn which are included, preventing npm install from succeeding.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: [email protected]

@scottgonzalez
Copy link
Contributor Author

Fixes #249.

@codecov
Copy link

codecov bot commented Aug 21, 2023 •
edited
Loading

Codecov Report

Patch coverage: 94.73% and project coverage change: 0.17% 🎉

Comparison is base (108d443) 91.15% compared to head (f69bc6a) 91.32%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #251       /-   ##
==========================================
  Coverage   91.15%   91.32%    0.17%     
==========================================
  Files           6        6              
  Lines         554      565       11     
==========================================
  Hits          505      516       11     
  Misses         49       49
Files Changed Coverage Δ
src/acorn-jsx-walk.js 100.00% <ø> (ø)
src/parser.js 90.73% <94.73%> ( 0.24%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheton cheton changed the title Parser updates Update parser to support multiple fallback keys Aug 21, 2023
@cheton cheton merged commit 9f9d300 into i18next:master Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheton cheton cheton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottgonzalez @cheton