Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve jsx parser to parse boolean props. #241

Merged
merged 1 commit into from
Jan 17, 2023
Merged

improve jsx parser to parse boolean props. #241

merged 1 commit into from
Jan 17, 2023

Conversation

geewoo94
Copy link
Contributor

Fixed issue #240

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@cheton cheton self-requested a review January 16, 2023 09:20
@cheton cheton force-pushed the improve-jsx-parser branch from 60a5d26 to 7c79cdc Compare January 17, 2023 16:37
@cheton cheton force-pushed the improve-jsx-parser branch from 7c79cdc to 9a3fbf2 Compare January 17, 2023 16:37
@codecov
Copy link

codecov bot commented Jan 17, 2023 •
edited
Loading

Codecov Report

Base: 90.92% // Head: 90.92% // No change to project coverage 👍

Coverage data is based on head (9a3fbf2) compared to base (4687b6a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #241    /-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files           6        6           
  Lines         562      562           
=======================================
  Hits          511      511           
  Misses         51       51
Impacted Files Coverage Δ
src/parser.js 90.19% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cheton cheton merged commit e299c42 into i18next:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheton cheton cheton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geewoo94 @cheton