feat: Add option to not display controls on pause #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huynhsontung
changed the title
|
LGTM! Rebased to resolve a conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often use screenshot software (e.g. pixpin, snipaste) to take a screenshot of the video directly and copy it to the clipboard, which is very easy to share. Therefore I seldom need to save the frame as a file. However, the controls keep displaying when paused, which is not convenient for taking screenshots directly. So I added a setting to control whether the controls will be displayed when paused. The controls will disappear after a while when paused. When pause with spacebar, it will not show the controls.