Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Whisper] patch float type on mps #35295

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

eustlb
Copy link
Contributor

@eustlb eustlb commented Dec 16, 2024

What does this PR do?

Fixes Vaibhavs10/insanely-fast-whisper#255

#34537 introduced casting to float64, which is not supported on the MPS backend.

@eustlb eustlb requested a review from ArthurZucker December 16, 2024 15:34
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you including in the patch!

@ArthurZucker ArthurZucker merged commit 9feae5f into huggingface:main Dec 16, 2024
23 of 25 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

ArthurZucker pushed a commit that referenced this pull request Dec 16, 2024
* fix float type on mps

* make
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac M1 - multiple issues preventing transcription
3 participants