Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-flow-builder: check track events with tests #2871

Merged
merged 10 commits into from
Jul 29, 2024

Conversation

Iru89
Copy link
Contributor

@Iru89 Iru89 commented Jul 11, 2024

Description

Add test to check when and how trackEvent function is called.
Update docs of README.md
Refactor tests to reduce repetitve code

Context

Review commit by commit.

  • The first 5 commits each add a test for trackEvent called.
  • The sixth commit update README adding documentation on how to add the trackEvent and getKnowledgebaseResposne functions to the flow builder plugin.
  • The rest of commits is a refactor that restructures folders and files. It also uses the createFlowBuilderPluginAndGetContents function in most of the tests to reduce the code and not to repeat the creation of requests in each test.

Approach taken / Explain the design

Testing

All the PR are changes to the tests.
Add tests to check when and how the trackEvent function is used and refactor the rest of the tests.

@Iru89 Iru89 force-pushed the plugin-flow-builder/tracking-tests-1 branch from 8382d31 to 515d168 Compare July 11, 2024 20:52
Copy link

github-actions bot commented Jul 11, 2024

Test Results

30 tests   30 ✅  5m 25s ⏱️
 6 suites   0 💤
 1 files     0 ❌

Results for commit 515d168.

♻️ This comment has been updated with latest results.

@Iru89 Iru89 changed the title Plugin flow builder/tracking tests 1 plugin-flow-builder: check track events with tests Jul 12, 2024
@Iru89 Iru89 requested review from vanbasten17 and AinaVendrell and removed request for vanbasten17 July 15, 2024 07:11
@Iru89 Iru89 marked this pull request as ready for review July 15, 2024 07:11
@Iru89 Iru89 merged commit 7f987e9 into master-lts Jul 29, 2024
4 checks passed
@Iru89 Iru89 deleted the plugin-flow-builder/tracking-tests-1 branch July 29, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants