implement Endpoint trait for Box<dyn Endpoint> #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
approved these changes
Sep 28, 2020
|
I just noticed this while going through the code for an unrelated reason. I'm still a bit new to rust but won't this cause an infinite recursion. For example: fn endpoint() -> Box<dyn tide::Endpoint<()>> {
Box::new(|_| async { Ok("") })
}
#[async_std::main]
async fn main() {
let mut app = tide::Server::new();
app.at("/").get(endpoint());
let _: tide::http::Response = app
.respond(tide::http::Request::new(
tide::http::Method::Get,
tide::http::Url::parse("http://example.com/").unwrap(),
))
.await
.unwrap();
}This code causes a stack overflow. |
|
Hmm yeah, good catch! I'll see if I can fix that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now adding endpoints dynamically is difficult because only types that implement the Endpoint trait directly can be added. When you don't know in advance which endpoint you want to add in a certain situation it can be useful to be able to add boxed endpoints. This implementation makes this possible.
I did not add any tests for this. It seems like a trivial piece of code where the test will probably be more fragile than the code itself.