Make femme dependency optional
#693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now is only installed via the `logger` feature. In order to do this we need the `std` feature from `log` crate.
Fishrock123
reviewed
Sep 7, 2020
| futures-util = "0.3.5" | ||
| log = { version = "0.4.8", features = ["std"] } |
There was a problem hiding this comment.
Currently the dependency tree looks like this
tide
-- kv-log-macro
-- log (features = ["kv_unstable"])
-- femme
-- log (features = ["kv_unstable", "std"])
However, tide actually relies on the std feature in the log crate being turned on. Otherwise you get the following error
the trait `log::kv::value::ToValue` is not implemented for `std::string::String`
Ideal way to solve this is actually like this: yoshuawuyts/kv-log-macro#7
|
merging as is for now, yosh will have to address the kv-log-macro thing some other time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the
femmedependency optional, enabled via theloggerfeature.Motivation and Context
Allows you to use a different log crate and
femmedoesn't have to be installed.Types of changes
Technically speaking this is a breaking change in the case where someone removed the
loggerfeature and still usedtide::log::LevelFilter.Checklist: