Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose server state #675

Merged
merged 1 commit into from
Aug 4, 2020
Merged

expose server state #675

merged 1 commit into from
Aug 4, 2020

Conversation

jbr
Copy link
Member

@jbr jbr commented Aug 3, 2020

Currently there's no way to get access to the state on a Server.

I ran into this trying to test an app with a database pool in the State. I had a reference to a Server and wanted to execute statements against the database, but there was no way of doing so.

How Has This Been Tested?

doctest

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jbr jbr merged commit fd6945c into http-rs:master Aug 4, 2020
@Fishrock123 Fishrock123 mentioned this pull request Oct 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@yoshuawuyts yoshuawuyts Awaiting requested review from yoshuawuyts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbr @Fishrock123