Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Upgrade the transformers version from 4.33.0 to 4.36.0 for Shardformer. #5505

Closed
wangbluo opened this issue Mar 25, 2024 · 2 comments
Closed

[FEATURE]: Upgrade the transformers version from 4.33.0 to 4.36.0 for Shardformer. #5505

wangbluo opened this issue Mar 25, 2024 · 2 comments
Assignees
@wangbluo
Labels
enhancement New feature or request

Comments

@wangbluo
Copy link
Contributor

wangbluo commented Mar 25, 2024 •
edited
Loading

Describe the feature

Shardformer was originally developed based on transformers==4.33.0. In response to our users" needs, it needs to be upgraded to version 4.36.0.
The main changes involve the models in the colossalai/shardformer/modeling directory.
@ver217 @KKZ20 Please take a look, thanks! :)
@wangbluo wangbluo added the enhancement New feature or request label Mar 25, 2024
This was referenced Mar 25, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@wangbluo wangbluo self-assigned this Mar 28, 2024
@insujang
Copy link
Contributor

insujang commented Apr 2, 2024

Hi! Thanks for this work. I am not a part of hpcaitech, but just wondering: are you planning to keep bumping the version up? Since HF transformers version is now 4.39.3, and I found that at least llama2 model many internal implementations have been changed, and it did not work.

@wangbluo wangbluo mentioned this issue Apr 11, 2024
Merged
1 task
@wangbluo
Copy link
Contributor Author

Hi! Thanks for this work. I am not a part of hpcaitech, but just wondering: are you planning to keep bumping the version up? Since HF transformers version is now 4.39.3, and I found that at least llama2 model many internal implementations have been changed, and it did not work.

Hi, we have already upload all the shardformer model to 4.39.3 version of transformers, so I guess this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangbluo wangbluo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@insujang @wangbluo