Linux: Suppress clang static analyzer warning in zfs_remove()

Clang's static analyzer points out that if we fail to find an extended attribute directory, but somehow find it when calculating delete_now and delete_now is true, we will have a NULL pointer dereference when we try to unlink the extended attribute directory. I am not sure if this is possible, but if it is, I do not see a sane way of handling this other than rolling back the transaction and retrying. For now, let us do an VERIFY_IMPLY(). If this trips, it will stop the transaction from committing, which will prevent an attribute directory leak. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Richard Yao <[email protected]> Closes openzfs#14575
hpc · Mar 8, 2023 · 66a38fd · 66a38fd
1 parent c2550a1
commit 66a38fd
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/module/os/linux/zfs/zfs_vnops_os.c b/module/os/linux/zfs/zfs_vnops_os.c
@@ -1089,6 1089,7 @@ zfs_remove(znode_t *dzp, char *name, cred_t *cr, int flags)
  !zn_has_cached_data(zp, 0, LLONG_MAX) &&
  xattr_obj == xattr_obj_unlinked &&
  zfs_external_acl(zp) == acl_obj;
  VERIFY_IMPLY(xattr_obj_unlinked, xzp);
  }
 
  if (delete_now) {