Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add initial render benchmark for React Final Form #77

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] Add initial render benchmark for React Final Form #77

wants to merge 2 commits into from

Conversation

chasingtherain
Copy link
Contributor

@chasingtherain chasingtherain commented Mar 24, 2023 •
edited
Loading

added ReactFinalFormInitialRenderBenchmark and benchmark test

crutchcorn
crutchcorn requested changes Mar 24, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
lib/benchmarks/initial-render.bench.tsx Outdated Show resolved Hide resolved
lib/benchmarks/initial-render.bench.tsx Outdated Show resolved Hide resolved
lib/benchmarks/initial-render.bench.tsx Outdated Show resolved Hide resolved
lib/benchmarks/initial-render.bench.tsx Outdated Show resolved Hide resolved
@chasingtherain
Copy link
Contributor Author

Hi @crutchcorn

Have made the changes as requested, pls help to review again

Thank you

@crutchcorn crutchcorn changed the title added ReactFinalFormInitialRenderBenchmark and benchmark test [WIP] Add initial render benchmark for React Final Form Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crutchcorn crutchcorn crutchcorn requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chasingtherain @crutchcorn