fix: throw correct pouchdb error in pull, push and sync

hoodiehq · Apr 12, 2020 · f27afc5 · f27afc5
1 parent 7560124
commit f27afc5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/lib/pull.js b/lib/pull.js
@@ -1,6  1,7 @@
 module.exports = pull
 
 var Promise = require('lie')
 var errors = require('pouchdb-errors')
 
 var toId = require('./utils/to-id')
 
@@ -12,7  13,6 @@ var toId = require('./utils/to-id')
  */
 function pull (state, docsOrIds) {
   var pulledObjects = []
-  var errors = state.db.constructor.Errors
 
   return Promise.resolve(state.remote)
 
@@ -25,7  25,8 @@ function pull (state, docsOrIds) {
       }
 
       if (docsOrIds && docsOrIds.filter(Boolean).length !== docsOrIds.length) {
-        return Promise.reject(errors.NOT_AN_OBJECT)
         reject(errors.NOT_AN_OBJECT)
         return
       }
 
       var replication = state.db.replicate.from(remote, {

diff --git a/lib/push.js b/lib/push.js
@@ -1,6  1,7 @@
 module.exports = push
 
 var Promise = require('lie')
 var errors = require('pouchdb-errors')
 
 var toId = require('./utils/to-id')
 
@@ -13,7  14,6 @@ var toId = require('./utils/to-id')
 
 function push (state, docsOrIds) {
   var pushedObjects = []
-  var errors = state.db.constructor.Errors
 
   return Promise.resolve(state.remote)
 
@@ -26,7  26,8 @@ function push (state, docsOrIds) {
       }
 
       if (docsOrIds && docsOrIds.filter(Boolean).length !== docsOrIds.length) {
-        return Promise.reject(errors.NOT_AN_OBJECT)
         reject(errors.NOT_AN_OBJECT)
         return
       }
 
       var replication = state.db.replicate.to(remote, {

diff --git a/lib/sync.js b/lib/sync.js
@@ -1,6  1,7 @@
 module.exports = sync
 
 var Promise = require('lie')
 var errors = require('pouchdb-errors')
 
 var toId = require('./utils/to-id')
 
@@ -12,7  13,6 @@ var toId = require('./utils/to-id')
  */
 function sync (state, docsOrIds) {
   var syncedObjects = []
-  var errors = state.db.constructor.Errors
 
   return Promise.resolve(state.remote)
 
@@ -25,7  25,8 @@ function sync (state, docsOrIds) {
       }
 
       if (docsOrIds && docsOrIds.filter(Boolean).length !== docsOrIds.length) {
-        return Promise.reject(errors.NOT_AN_OBJECT)
         reject(errors.NOT_AN_OBJECT)
         return
       }
 
       var replication = state.db.sync(remote, {