Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for "Web Framework Benchmark" #1506

Open
yusukebe opened this issue Sep 25, 2023 · 2 comments
Open

Fix for "Web Framework Benchmark" #1506

yusukebe opened this issue Sep 25, 2023 · 2 comments
Labels
enhancement New feature or request.

Comments

@yusukebe
Copy link
Member

yusukebe commented Sep 25, 2023 •
edited
Loading

What is the feature you are proposing?

The following benchmark results show a very low score for Hono:

Web Frameworks Benchmark

This is because it is failing to fork the process in pm2.

Screenshot 2023-09-26 at 4 38 58

Only one process is up and running because of a port conflict.

Screenshot 2023-09-26 at 4 40 26

I can think of several ways, anyway we have to resolved it.
@yusukebe yusukebe added the enhancement New feature or request. label Sep 25, 2023
@yusukebe
Copy link
Member Author

yusukebe commented Oct 4, 2023

I’ve fixed a port conflict issue with the PR: the-benchmarker/web-frameworks#6763 . But it only prevents errors and does not improve performance.

Other Node.js web frameworks such as Fastify are clustered using pm2. However, the Hono apps that run on top of bun are just forked. Since this benchmark only accesses port 3000, there is no point in forking. So I don't think it makes sense to use pm2.

@sparanoid
Copy link

Hono just added node:cluster support oven-sh/bun#2428 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yusukebe @sparanoid