Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up superfluous integration setup - part 5 #49296

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Clean up superfluous integration setup - part 5 #49296

merged 2 commits into from
Apr 16, 2021

Conversation

frenck
Copy link
Member

@frenck frenck commented Apr 16, 2021

Proposed change

#48381 remove the need for an integration setup or async_setup in case the integration provides a async_setup_entry. For example:

async def async_setup(hass, config):
    """Component setup, do nothing."""
    return True

This PR is cleanup for those (or similar).

TODO:

  • Cleanup tests

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck frenck marked this pull request as draft April 16, 2021 11:57
@frenck frenck marked this pull request as ready for review April 16, 2021 15:45
@balloob balloob merged commit af80ca6 into dev Apr 16, 2021
@balloob balloob deleted the frenck-2021-1178 branch April 16, 2021 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants