Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformize platform setup #47101

Merged
merged 11 commits into from
Mar 2, 2021
Merged

Conversation

Quentame
Copy link
Member

@Quentame Quentame commented Feb 26, 2021

Proposed change

Global changes about naming to setup a platform, often the term "component" is used, and even some times "domain", globally, the changes are :

  • for component in PLATFORMS
  • for component in COMPONENTS
  • for component in [X]_COMPONENTS
  • for domain in DOMAINS
  • for domain in [X]_DOMAINS

Now ==> for platform in PLATFORMS

I also created PLATFORMS const when having list of platforms into the foreach (like verisure).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Quentame Quentame changed the title A platform is not a component Uniformize platform setup Feb 26, 2021
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fine when the tests pass 👍

@MatthewFlamm

This comment has been minimized.

@Quentame Quentame merged commit 198ecb0 into home-assistant:dev Mar 2, 2021
@Quentame Quentame deleted the common/platform-name branch March 2, 2021 20:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants