Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable async_update for entities in NWS #35048

Merged
merged 3 commits into from
May 8, 2020

Conversation

MatthewFlamm
Copy link
Contributor

@MatthewFlamm MatthewFlamm commented May 1, 2020

Proposed change

This PR enables async_update which allows users to run manual updates as suggested in this comment. The Debouncer cooldown time is set to 60s to avoid too many updates by users.

I removed the unused config schema which is unneeded and was missed in the conversation to config flow.

PARALLEL_UPDATES is also set, which I think brings this integration up to Platinum level on the quality scale.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

I am following [guidance] (https://www.weather.gov/disclaimer) to limit API calls to no more than once a minute.

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@MatthewFlamm MatthewFlamm marked this pull request as draft May 2, 2020 13:04
@MatthewFlamm
Copy link
Contributor Author

Having trouble testing that the Debouncer is working the way I think it does, so marked as draft.

@MatthewFlamm MatthewFlamm marked this pull request as ready for review May 2, 2020 15:13
@MatthewFlamm
Copy link
Contributor Author

Figured it out, it wasnt worth trying to test the actual Debouncer behavior. It just didn't work as I expected at first.

@bdraco
Copy link
Member

bdraco commented May 8, 2020

Screen Shot 2020-05-07 at 10 42 50 PM

Screen Shot 2020-05-07 at 10 42 37 PM

Looks good, tested and working as expected.

@bdraco bdraco merged commit 7ac547a into home-assistant:dev May 8, 2020
@lock lock bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants