Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObserverSpy swallows errors #20

Closed
shairez opened this issue Sep 29, 2020 · 1 comment
Closed

ObserverSpy swallows errors #20

shairez opened this issue Sep 29, 2020 · 1 comment
Assignees
Labels

Comments

@shairez
Copy link
Member

shairez commented Sep 29, 2020

Describe the bug

When an error is thrown unexpectedly, the error method on the ObserverSpy catches it and basically "hides" it from the user.

And by that making debugging an unexpected error much more difficult.

To Reproduce
Steps to reproduce the behavior:

  1. throw an error in an observable
  2. See no trace of it in the logs

Expected behavior
We should be able to configure the observer spy (on creation or via subscribeSpyTo) to flag whether an error is expected or not.

The default should be that the error is not expected and should be re-thrown so it would be shown in the console.

@shairez shairez self-assigned this Sep 29, 2020
@shairez
Copy link
Member Author

shairez commented Sep 29, 2020

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant