-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ObserverSpy
swallows errors
#20
Labels
Comments
🎉 This issue has been resolved in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When an error is thrown unexpectedly, the
error
method on theObserverSpy
catches it and basically "hides" it from the user.And by that making debugging an unexpected error much more difficult.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
We should be able to configure the observer spy (on creation or via
subscribeSpyTo
) to flag whether an error is expected or not.The default should be that the error is not expected and should be re-thrown so it would be shown in the console.
The text was updated successfully, but these errors were encountered: