Fix ':scheme' for posix client (grpc#1972)

Motivation: The client doesn't support TLS (yet) but uses the 'https' scheme. Modifications: - Use the correct scheme - Add tests Result: Fewer bugs
hharng · Jul 8, 2024 · 951b4d3 · 951b4d3
1 parent 595a416
commit 951b4d3
Show file tree

Hide file tree

Showing 2 changed files with 57 additions and 1 deletion.
diff --git a/Sources/GRPCHTTP2TransportNIOPosix/HTTP2ClientTransport Posix.swift b/Sources/GRPCHTTP2TransportNIOPosix/HTTP2ClientTransport Posix.swift
@@ -144,7 144,7 @@ extension HTTP2ClientTransport.Posix {
  }
  }
 
- return HTTP2Connection(channel: channel, multiplexer: multiplexer, isPlaintext: false)
  return HTTP2Connection(channel: channel, multiplexer: multiplexer, isPlaintext: true)
  }
  }
 }

diff --git a/Tests/GRPCHTTP2TransportTests/HTTP2TransportTests.swift b/Tests/GRPCHTTP2TransportTests/HTTP2TransportTests.swift
@@ -1353,6 1353,62 @@ final class HTTP2TransportTests: XCTestCase {
  }
  }
  }
 
  func testUnaryScheme() async throws {
  try await self.forEachTransportPair { control, pair in
  let input = ControlInput.with {
  $0.echoMetadataInHeaders = true
  $0.numberOfMessages = 1
  }
  let request = ClientRequest.Single(message: input)
  try await control.unary(request: request) { response in
  XCTAssertEqual(Array(response.metadata["echo-scheme"]), ["http"])
  }
  }
  }
 
  func testServerStreamingScheme() async throws {
  try await self.forEachTransportPair { control, pair in
  let input = ControlInput.with {
  $0.echoMetadataInHeaders = true
  $0.numberOfMessages = 1
  }
  let request = ClientRequest.Single(message: input)
  try await control.serverStream(request: request) { response in
  XCTAssertEqual(Array(response.metadata["echo-scheme"]), ["http"])
  }
  }
  }
 
  func testClientStreamingScheme() async throws {
  try await self.forEachTransportPair { control, pair in
  let request = ClientRequest.Stream(of: ControlInput.self) { writer in
  let input = ControlInput.with {
  $0.echoMetadataInHeaders = true
  $0.numberOfMessages = 1
  }
  try await writer.write(input)
  }
  try await control.clientStream(request: request) { response in
  XCTAssertEqual(Array(response.metadata["echo-scheme"]), ["http"])
  }
  }
  }
 
  func testBidiStreamingScheme() async throws {
  try await self.forEachTransportPair { control, pair in
  let request = ClientRequest.Stream(of: ControlInput.self) { writer in
  let input = ControlInput.with {
  $0.echoMetadataInHeaders = true
  $0.numberOfMessages = 1
  }
  try await writer.write(input)
  }
  try await control.bidiStream(request: request) { response in
  XCTAssertEqual(Array(response.metadata["echo-scheme"]), ["http"])
  }
  }
  }
 }
 
 @available(macOS 14.0, iOS 17.0, watchOS 10.0, tvOS 17.0, *)